Skip to content

Commit 2102a6a

Browse files
morningmanclaude
andcommitted
[chore](metrics) Say which disables drop the snapshot of the changelog monitor
### What problem does this PR solve? Issue Number: apache#69907 Related PR: apache#69848 Problem Summary: Where the monitor drops its snapshot, the comment said that once enabled again, the monitor must not export what it sampled before it was disabled. The monitor reads the flag at its checks, once a second, so this holds for a disable a check finds. A toggle between two checks, or a disable during a round undone before the next check, goes unseen, and the latest round is then exported as if the monitor had never been disabled. The comment now says what is dropped and when. No code changes. ### Release note None ### Check List (For Author) - Test: No need to test (a comment only) - Behavior changed: No - Does this need documentation: No Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 2b4354c commit 2102a6a

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎fe/fe-core/src/main/java/org/apache/doris/changelog/ChangelogMonitor.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ public static boolean isEnabled() {
6363
@Override
6464
protected void runAfterCatalogReady() {
6565
if (!isEnabled()) {
66-
// Once enabled again, the monitor must not export what it sampled before it was disabled.
66+
// A check that finds the monitor disabled drops the snapshot: once enabled again, the monitor does not
67+
// export what it sampled before, and the sampled series are missing until a round completes.
6768
snapshot = null;
6869
return;
6970
}

0 commit comments

Comments
 (0)