Repository navigation
fix(browser): report non-absolute export paths at their input field - #7097
Merged
morluto merged 1 commit intoOct 27, 2026
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; field-specific errors preserve the existing path restrictions. SummaryReports each relative export path at its own input field instead of returning one combined error.
Reviews (1) · Last reviewed commit: "fix(browser): report non-absolute export..." · Reviewed by Greptile |
saiyam-jain-dev
marked this pull request as ready for review
October 25, 2026 09:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 tasks done
8 of 11 tasks
SanHsien
added a commit
to SanHsien/rea
that referenced
this pull request
Oct 27, 2026
…ee sync) Bring the fork from upstream 988494a to the rea-agents-6.8.0 release (160d821, 1914 upstream commits) as one net-tree commit. The squashed fork shares no ancestor with upstream, so a never-pushed synthetic commit (parent 988494a, fork tree) restored a three-way merge base; only the resulting tree is committed here. Recorded as the PLAYBOOK §5 exception in docs/DECISIONS.md and docs/records/upstream-sync-evaluation-2026-10-27.md. Kept fork changes: - zh-TW default README, README.en.md mirror, en + zh-TW locales only; upstream README additions translated into Traditional Chinese - Windows hardening where upstream has no equivalent fix (GhidraInstallation drive-letter JAVA_HOME, MacHopperPaths Windows home joins, Electron symlink tests skipped on win32) - zod 4.6.7 and fast-uri 3.1.9 security pins; generated schema and license inventories regenerated, runtime notices updated Adopted early: upstream 4557791 (morluto#7152), a v-mode portable Windows absolute-path pattern, so MCP clients that compile advertised patterns with the v flag accept the tool list on Windows. Workflow review: fork guards (github.repository == 'morluto/rea') on the publication roots of release.yml (merged-release, release-please), release-recovery.yml (verify) and website-pages.yml (prepare). Upstream check now tracks releases: tools/check_upstream_updates.py is the repo-fleet-ops canonical checker (84bc069, byte-identical); tools/upstream_baseline.json uses track=release, release_tag_prefix rea-agents- and ticket_cutoff=release; the workflow runs it with --ticket-cap 3000. Watermarks: release rea-agents-6.8.0, PR morluto#7097, issue morluto#7095. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When caller-supplied paths to
export_web_scripts(capture_pathoroutput_directory) are relative,WebScriptExportServicepreviously emitted a single generic issue with an empty issue path (path: []) and a combined message"capture_path and output_directory must be absolute filesystem paths on this host."even if only one of them was relative. This PR reports non-absolute paths at their respective field (["capture_path"]and/or["output_directory"]), matching the established boundary issue reporting pattern across REA.Problem and expected behavior
Previously, passing a relative
capture_pathoroutput_directoryreturned:{ "path": [], "reason": "invalid_format", "message": "capture_path and output_directory must be absolute filesystem paths on this host." }Consumers could not determine from the structured issue which argument violated the absolute path requirement. The expected behavior is that each invalid field is reported with its own issue targeting
["capture_path"]or["output_directory"].Change and scope
exportWebScriptsValidatedinsrc/application/WebScriptExportService.tsto inspectcapture_pathandoutput_directoryindividually and return targetedAnalysisInputIssuerecords for each invalid field.tests/boundary/filesystem/webScriptExport.test.tsverifying issue paths and reasons whencapture_pathis relative,output_directoryis relative, or both are relative.Contribution scope fit: ordinary boundary fix within existing boundaries (not applicable).
Contract and boundary impact
src/application/WebScriptExportService.tsinput validation.AnalysisInputErrornow identifiescapture_pathand/oroutput_directoryinissues[].path.docs/public/product-catalog.json), package, or installation impact: none.Expected effects:
Evidence and regression coverage
tests/boundary/filesystem/webScriptExport.test.ts{ path: [], reason: "invalid_format" }.capture_pathoroutput_directory.For evidence-bearing changes:
Validation performed
npx vitest run tests/boundary/filesystem/webScriptExport.test.ts -t "identifies a missing capture file and rejected host path syntax"— passed (1 passed in 34ms)npm run check:fast(turbo run typecheck lint) — passed cleanly (2/2 tasks successful in 1m21s)Compatibility, safety, and release
Author readiness
Human owner: @saiyam-jain-dev
Before merge
type(scope): outcome.