Repository navigation
test(artifacts): skip directory symlink traversal test on Windows without symlink privileges - #10542
Conversation
…hout symlink privileges
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
[Low impact] This test-only change appears safe to merge. SummaryAdds
Reviews (1) · Last reviewed commit: "test(artifacts): skip directory symlink ..." · Reviewed by Greptile |
Summary
Skips the directory symlink traversal test in
ReleaseExposureReader.test.tson Windows where unprivileged symlink creation fails withEPERM.Problem and expected behavior
In
src/artifacts/ReleaseExposureReader.test.ts(line 2661), the test"keeps symlink traversal in a selected directory path"attempts to create a directory symlink usingawait symlink(join(root, "real", "child"), join(root, "link")).On Windows, creating symlinks without Developer Mode or elevated privileges (
SeCreateSymbolicLinkPrivilege) throwsEPERM: operation not permitted, symlink.Other symlink tests in this file (lines 1204, 1226, 1246, 1259, 4794, 4835) already use
it.skipIf(process.platform === "win32"), but line 2661 missed the guard.Expected behavior: The test should be skipped on Windows when run unprivileged, matching the rest of the test suite.
Change and scope
it.skipIf(process.platform === "win32").Contract and boundary impact
Expected effects:
Evidence and regression coverage
src/artifacts/ReleaseExposureReader.test.tskeeps symlink traversal in a selected directory paththrowsEPERMon Windows without symlink privileges.For evidence-bearing changes:
Validation performed
EPERMerrors.Compatibility, safety, and release
Author readiness
Human owner: @pellurusaranya-byte
Before merge
type(scope): outcome.