Repository navigation
test: make registration-format and release-exposure suites pass on Windows - #10533
Plastic-time wants to merge 2 commits into
Conversation
…ndows The Windows-only Fx case still read mcp.rea, but a new Fx profile is written under mcpServers. Two Fx cases assert POSIX modes or a private-directory close that Windows never performs; they now run off Windows, beside the existing Windows case. Two release-exposure assertions spelled paths with a POSIX separator; one now accepts either separator and one uses the reader's host-file/member spelling.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
[Low impact] This test-only PR appears safe to merge. SummaryFixes five Windows test failures without changing production code.
No actionable issues found. Tests were not run during this review. Supersession could not be checked because GitHub access required authentication. Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile |
…-registration-exposure-tests
Summary
Five source tests in two files failed on Windows for test-only reasons. They now pass there, and Linux and macOS run the same assertions as before.
Fixes #10532
Problem and expected behavior
src/application/McpClientRegistration.formats.test.ts:mcp.rea, but a new Fx profile is written undermcpServers(fxConfigurationServersKey). It failed withCannot read properties of undefined (reading 'rea').verified_posix_modes. Windows reportsrequested_windows_modes, which the case above covers.registerMcpClientskipssecurePrivateDirectoryon win32, so nothing fails there.src/artifacts/ReleaseExposureReader.test.ts:/bin\/app\.map$/. Windows reports...\bin\app.map.join(root, "app.dll", "payload.bin"). The reader names a packaged member as${hostFile}/${memberPath}, so Windows reports...\app.dll/payload.bin.Change and scope
mcpServers.rea.it.runIf(process.platform !== "win32"), mirroring the existingit.runIf(process.platform === "win32")case. Their behavior does not exist on Windows.Contribution scope: ordinary test portability fix; maintainer scope decision not applicable.
Contract and boundary impact
Semantic owner and earliest changed stage: tests only.
Contribution scope fit and linked maintainer decision: not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: Windows test portability.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata, package, or installation impact: none.
Documentation or usability only; no target interaction.
Evidence and regression coverage
EPERMfromsymlinkbecause this Windows account cannot create symlinks. It is unchanged and not addressed here.Validation performed
Windows 11 Home 10.0.26200 x64, Node 24.22.1, base 55c9e8e.
npx vitest run src/application/McpClientRegistration.formats.test.ts src/artifacts/ReleaseExposureReader.test.tson main: 6 failed / 283 passed / 10 skipped; with this change: 1 failed / 286 passed / 12 skipped.npm run check:fast: passed (typecheck, lint).tests/boundary/mcp/contractPresentation.test.ts> "cleans up a child that ignores its deadline signal", a timing case this PR does not touch; main passed CI on the same base 55c9e8e. After the merge the two files still give 1 failed (the symlinkEPERM) / 286 passed / 12 skipped, andcheck:fastpasses.Compatibility, safety, and release
Author readiness
Human owner: @Plastic-time
Before merge
type(scope): outcome.