Skip to content

docs(skill): clarify ASAR inventory-first routing and provider selection - #10505

Open
BeqaKs wants to merge 1 commit into
morluto:mainfrom
BeqaKs:cursor/docs-10501-asar-skill-routing-ebba
Open

BeqaKs wants to merge 1 commit into
morluto:mainfrom
BeqaKs:cursor/docs-10501-asar-skill-routing-ebba

Conversation

@BeqaKs

@BeqaKs BeqaKs commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #10501.

Clarify skill routing for large Electron app.asar targets: inventory first with open_binary + inspect_artifact(detail: "summary"), pass narrowed source_paths to analyze_javascript_application, use integrity_policy: "record-and-continue" when .unpacked companions were re-signed after packing, and select an explicit provider_id (or call binary_session({})) when multiple deep providers may be configured.

Problem and expected behavior

Skill v62 routed ASAR/Electron trees straight to analyze_javascript_application without size/scope guards, omitted integrity_policy for post-packing re-signed .unpacked binaries, and documented provider_id for ida/kuna but not multi-provider ghidra/hopper ambiguity. Agents then hit whole-ASAR host deadlines, artifact_integrity_mismatch, and capability_unavailable (selection_reason: "ambiguous"). Expected: progressive-disclosure routing guards in SKILL.md with details in references/javascript-applications.md.

Change and scope

Authored skill only (.agents/skills/reverse-engineer-anything/ plus regenerated .cursor-plugin/skills/ mirror):

  1. SKILL.md ASAR bullet — inventory-first + source_paths for large packages; integrity_policy: "record-and-continue" when retaining contradictions.
  2. SKILL.md native open_binary bullet — explicit provider_id or binary_session({}) when multiple deep providers may be present.
  3. references/javascript-applications.md — large-ASAR inventory pattern next to the existing detail: "summary" note; Electron .unpacked integrity policy guidance.

No runtime, catalog, or provider behavior changes.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contract and boundary impact

  • Semantic owner and earliest changed stage: authored skill instructions; agent routing consumers of ASAR/Electron and multi-provider open_binary guidance.
  • Contribution scope fit and linked maintainer decision: documentation within existing tool contracts; not applicable.
  • CLI and MCP/tool-catalog contract: none.
  • Provider, bridge, target-format, or platform compatibility: none (documents existing integrity_policy and provider selection behavior).
  • Evidence, artifact, provenance, or reconstruction contract: none.
  • Target selection, authority, upstream behavior, and cleanup details (if applicable): none.
  • Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): Cursor plugin skill mirror regenerated; no package version change.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Validation performed

  • node scripts/generate-cursor-plugin-skill.mjs --check — passed
  • npm run check:fast — typecheck and lint passed

Compatibility, safety, and release

  • Breaking changes or migration steps: none.
  • Real Hopper/Ghidra, browser, or OS coverage: not required for documentation-only routing clarification.
  • Package or release metadata impact: none (skill text only; version metadata unchanged).
  • Security, privacy, process, or containment review: none; documents existing read-only observation options.

Author readiness

Human owner: @BeqaKs

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

Document large-ASAR source_paths inventory, integrity_policy for re-signed
unpacked companions, and explicit provider_id when multiple deep providers
are configured.

Fixes morluto#10501
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-14T10:37:05.067823Z
We couldn’t complete this review. Comment @codex review to try again.
67d83fa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The changes affect agents that use the reverse-engineering skill and its Cursor mirror.

The documentation appears safe to merge, with a non-blocking correction needed for the inventory-first workflow.

Findings

  1. P2 Inventory still rejects re-signed companions ▶
Fix with agent prompt
### Issue 1
.agents/skills/reverse-engineer-anything/references/javascript-applications.md:32-35
The new route calls `inspect_artifact` before analysis, but this guidance prescribes `integrity_policy: "record-and-continue"` only for `analyze_javascript_application` and `extract_artifact`. With re-signed `.unpacked` companions, inspection uses the default `fail` policy and returns `artifact_integrity_mismatch` before the agent reaches analysis. Include `inspect_artifact` in the policy guidance and update the Cursor mirror too.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Updates the authored skill and Cursor mirror with:

  • Large ASAR analysis starts with an inventory when only selected files are needed.
  • Electron analysis can keep going when unpacked files were re-signed.
  • Native analysis tells agents how to choose among configured providers.

One non-blocking documentation fix remains: apply the integrity policy to inspect_artifact too.

Supersession could not be checked because GitHub access was unavailable. No security issue was identified in the reviewed changes.

Reviews (1) · Last reviewed commit: "docs(skill): clarify ASAR inventory-firs..." · Reviewed by Greptile

Comment on lines +32 to +35
`detail: "summary"`. Pass `integrity_policy: "record-and-continue"` on
`analyze_javascript_application` and `extract_artifact` when an Electron `.app`
bundle's `app.asar.unpacked` native companions were re-signed after ASAR
creation and retaining declared-vs-observed digest contradictions is intended;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Inventory still rejects re-signed companions

The new route calls inspect_artifact before analysis, but this guidance prescribes integrity_policy: "record-and-continue" only for analyze_javascript_application and extract_artifact. With re-signed .unpacked companions, inspection uses the default fail policy and returns artifact_integrity_mismatch before the agent reaches analysis. Include inspect_artifact in the policy guidance and update the Cursor mirror too.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .agents/skills/reverse-engineer-anything/references/javascript-applications.md
Line: 32-35

Comment:
**Inventory still rejects re-signed companions**

The new route calls `inspect_artifact` before analysis, but this guidance prescribes `integrity_policy: "record-and-continue"` only for `analyze_javascript_application` and `extract_artifact`. With re-signed `.unpacked` companions, inspection uses the default `fail` policy and returns `artifact_integrity_mismatch` before the agent reaches analysis. Include `inspect_artifact` in the policy guidance and update the Cursor mirror too.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] Skill v62: clarify ASAR inventory-first routing, integrity_policy, and multi-provider open_binary selection

1 participant