Add dft and idft #847
Merged
Add dft and idft #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
commented
May 30, 2024
rhettinger
reviewed
May 30, 2024
|
|
||
| class DiscreteFourierTransformTests(TestCase): | ||
| def test_basic(self): | ||
| xarr = [1, 2 - 1j, -1j, -1 + 2j] |
Contributor
There was a problem hiding this comment.
Suggest adding a comment that links back to the wikipedia example which is worked out step-by-step: # https://en.wikipedia.org/wiki/Discrete_Fourier_transform#Example.
rhettinger
reviewed
May 30, 2024
rhettinger
reviewed
May 30, 2024
Contributor
|
Title has a typo, says |
Collaborator
Author
|
Thanks, I fixed the title. The |
Contributor
|
LGTM :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
dftandidft, contributed by @rhettinger in #843.Additionally, the docs now have a separate section for the various math-related functions.