Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 21, 2022

Such as input the wrong command line parameters
The original error will be panic since log is not init.
image
After fix.
image

@ghost
Copy link
Author

ghost commented Oct 23, 2022

The linter 'varcheck' 'deadcode' 'structcheck' is deprecated (since v1.49.0), use 'unused' instead.

@ghost ghost changed the title fix: log error fix: log error & remove deprecated linter Oct 23, 2022
@moonD4rk moonD4rk self-assigned this Oct 24, 2022
@moonD4rk
Copy link
Owner

The linter 'varcheck' 'deadcode' 'structcheck' is deprecated (since v1.49.0), use 'unused' instead.

THX, I will remove this lint, you could revert lint commit~

Copy link
Owner

@moonD4rk moonD4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert golangci config file, and change log to Println and os.Exit, Thx

@moonD4rk moonD4rk changed the base branch from master to fix/logbug October 24, 2022 06:00
@moonD4rk moonD4rk merged commit 20fdd7a into moonD4rk:fix/logbug Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant