Skip to content

fix(packs): cover all five bundled advisories in the publishing pack's security note - #131

Merged
enri3l merged 1 commit into
mainfrom
fix/publishing-security-note
Oct 8, 2026
Merged

enri3l merged 1 commit into
mainfrom
fix/publishing-security-note

Conversation

@enri3l

@enri3l enri3l commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

What and why

The publishing pack's shipped adoptNotes security note (dated 2026-10-01) named only undici, ip-address and brace-expansion. Since then two more advisories opened against packages bundled inside the pinned npm (see #129), so the note shipped to every pack user was incomplete, and its "bump as soon as a release bundling..." criterion would not have caught them. This rewrites it to cover all five, dated 2026-10-08, and ships as a patch changeset (it is shipped output).

No files/, budget, wiring, setupSteps or modes change. The adoptNotes-vs-setupSteps drift guard still holds (the four setup commands are untouched).

Review

baseline-impact-reviewer found nothing must-fix (structural contracts, no test asserts on the note text, no length limit on adoptNotes); one nit, naming 4.3.0 in the note, is applied. A code-reviewer fact-checked every claim in the shipped text against primary sources and found all verified. I re-checked the two upstream PRs and #10060 myself.

Verified locally: pnpm typecheck, lint, test, format:check and the docs-site and license-header checks pass via the pre-push hook. e2e runs in CI.

Checklist

  • pnpm verify passes (the pre-push hook ran build, typecheck, format, test and lint)
  • pnpm test:e2e passes (not run locally: no packages/cli/src/ or templates/core/ change, one adoptNotes string in a pack; CI runs it)
  • Every commit is signed off (DCO, git commit -s) and GPG-signed
  • New functionality has tests (n/a: wording of a shipped note; the existing drift guard covers it)
  • A changeset is included (patch)
  • Baseline caps still hold (n/a)
  • A new file under templates/core/ is claimed by domain-map.ts (n/a)
  • A new tracked file outside templates/** carries an SPDX header (n/a)

🤖 Generated with Claude Code

…s security note

The shipped adoptNotes security note (dated 2026-10-01) named only
undici, ip-address and brace-expansion. It now covers all five packages
bundled inside the pinned npm that carry open advisories, adding
postcss-selector-parser 7.1.4 and http-cache-semantics 4.2.0 with why
neither is reached from the shipped release workflow (the parser is
called only by npm query and npm sbom; make-fetch-happen's cache policy
is shared: false).

The bump criterion now includes postcss-selector-parser >= 7.1.6 and
names the open upstream fixes (npm/cli#10088 and #10089). It says
http-cache-semantics has no fixed release: 4.3.0 is outside the
advisory's range but upstream closed the report as not planned, so a
bump past 4.2.0 only clears the alert.

docs/security-review.md records the same, the upstream PRs and the
re-check signal, and notes that release PR #10060 carries none of the
bumps. Patch changeset because the note ships to users.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Signed-off-by: Enrico Lionello <[email protected]>
@enri3l
enri3l merged commit 4dede2d into main Oct 8, 2026
14 checks passed
@enri3l
enri3l deleted the fix/publishing-security-note branch October 8, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant