Repository navigation
fix(packs): cover all five bundled advisories in the publishing pack's security note - #131
Merged
Merged
Conversation
…s security note The shipped adoptNotes security note (dated 2026-10-01) named only undici, ip-address and brace-expansion. It now covers all five packages bundled inside the pinned npm that carry open advisories, adding postcss-selector-parser 7.1.4 and http-cache-semantics 4.2.0 with why neither is reached from the shipped release workflow (the parser is called only by npm query and npm sbom; make-fetch-happen's cache policy is shared: false). The bump criterion now includes postcss-selector-parser >= 7.1.6 and names the open upstream fixes (npm/cli#10088 and #10089). It says http-cache-semantics has no fixed release: 4.3.0 is outside the advisory's range but upstream closed the report as not planned, so a bump past 4.2.0 only clears the alert. docs/security-review.md records the same, the upstream PRs and the re-check signal, and notes that release PR #10060 carries none of the bumps. Patch changeset because the note ships to users. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Signed-off-by: Enrico Lionello <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The
publishingpack's shippedadoptNotessecurity note (dated 2026-10-01) named only undici, ip-address and brace-expansion. Since then two more advisories opened against packages bundled inside the pinned npm (see #129), so the note shipped to every pack user was incomplete, and its "bump as soon as a release bundling..." criterion would not have caught them. This rewrites it to cover all five, dated 2026-10-08, and ships as a patch changeset (it is shipped output).postcss-selector-parser7.1.4 is called only bynpm queryandnpm sbom(neither runs in the release flow), andhttp-cache-semantics4.2.0 sits behind make-fetch-happen's private (shared: false) cache. Both statements were verified against the unpacked npm 12.2.0 and 11.20.0 tarballs, including everynew CacheSemanticscall site.postcss-selector-parser >= 7.1.6and names the open upstream fixes deps: resolve production audit vulnerabilities npm/cli#10088 (12.x) and #10089 (11.x backport), both open and unmerged as of 2026-10-08.http-cache-semanticshas no fixed release: 4.3.0 is outside the advisory's range, but upstream closed the report as not planned (Security Advisory:max-stalerequest directive overrides shared-cache reuse prohibitions (Set-Cookie, proxy-revalidate) kornelski/http-cache-semantics#56) and the advisory is disputed in GHSA-ch52-4w7c-c8xp (CVE-2026-93748) claim of bogus report by repo owner github/advisory-database#10139, so a bump past 4.2.0 only clears the alert. The note says so.docs/security-review.mdrecords the same, adds the upstream PRs to the "upstream fix in progress" row, adds the re-check signal (a new npm release after #10088 or #10089 merges), and notes that the open release PR chore: release 12.2.1 npm/cli#10060 (12.2.1) carries only the #9941 bug fix and none of the five bumps.No
files/,budget,wiring,setupStepsormodeschange. TheadoptNotes-vs-setupStepsdrift guard still holds (the four setup commands are untouched).Review
baseline-impact-reviewerfound nothing must-fix (structural contracts, no test asserts on the note text, no length limit onadoptNotes); one nit, naming 4.3.0 in the note, is applied. Acode-reviewerfact-checked every claim in the shipped text against primary sources and found all verified. I re-checked the two upstream PRs and #10060 myself.Verified locally:
pnpm typecheck,lint,test,format:checkand the docs-site and license-header checks pass via the pre-push hook. e2e runs in CI.Checklist
pnpm verifypasses (the pre-push hook ran build, typecheck, format, test and lint)pnpm test:e2epasses (not run locally: nopackages/cli/src/ortemplates/core/change, oneadoptNotesstring in a pack; CI runs it)git commit -s) and GPG-signedtemplates/core/is claimed bydomain-map.ts(n/a)templates/**carries an SPDX header (n/a)🤖 Generated with Claude Code