AgentSpan: add isFinished() method

monosoul · monosoul · commit c31c62d09da4 · 2023-01-08T16:05:41.000+01:00
Signed-off-by: monosoul &lt;Kloz.Klaud@gmail.com&gt;
diff --git a/dd-java-agent/agent-profiling/profiling-context/src/test/java/com/datadog/profiling/context/TestSpan.java b/dd-java-agent/agent-profiling/profiling-context/src/test/java/com/datadog/profiling/context/TestSpan.java
@@ -255,6 +255,11 @@ public AgentSpan setBaggageItem(final String key, final String value) {
     return this;
   }
 
+  @Override
+  public boolean isFinished() {
+    return false;
+  }
+
   @Override
   public void finish() {}
 
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/DDSpan.java b/dd-trace-core/src/main/java/datadog/trace/core/DDSpan.java
@@ -137,6 +137,7 @@ public int applyAsInt(ByteBuffer byteBuffer) {
         }
       };
 
+  @Override
   public boolean isFinished() {
     return durationNano != 0;
   }
diff --git a/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentSpan.java b/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentSpan.java
@@ -69,6 +69,8 @@ public interface AgentSpan extends MutableSpan, IGSpanInfo {
 
   short getHttpStatusCode();
 
+  boolean isFinished();
+
   void finish();
 
   void finish(long finishMicros);
diff --git a/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java b/internal-api/src/main/java/datadog/trace/bootstrap/instrumentation/api/AgentTracer.java
@@ -630,6 +630,11 @@ public AgentSpan setBaggageItem(final String key, final String value) {
       return this;
     }
 
+    @Override
+    public boolean isFinished() {
+      return false;
+    }
+
     @Override
     public void finish() {}
 

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,7 @@ public int applyAsInt(ByteBuffer byteBuffer) {`
`137`	`137`	`}`
`138`	`138`	`};`
`139`	`139`
	`140`	`+ @Override`
`140`	`141`	`public boolean isFinished() {`
`141`	`142`	`return durationNano != 0;`
`142`	`143`	`}`