fix(test): unwrap IssueL through .base.id in ErrorPatternsSpec

tonyalaribe · tonyalaribe · commit f0ab87d7ea27 · 2026-05-02T21:12:15.000+02:00
IssueL is a list-view wrapper around Issue (`{ base :: Issue, ... }`),
so the `id` field is reached through `.base`. Four sites in
ErrorPatternsSpec called `issue.id` directly, which type-errored after
IssueL gained its current shape. Matches the pattern used in
src/Pages/Anomalies.hs (`errL.base.id`).
diff --git a/test/integration/Pages/ErrorPatternsSpec.hs b/test/integration/Pages/ErrorPatternsSpec.hs
@@ -242,7 +242,7 @@ spec = aroundAll withTestResources do
 
       -- Acknowledge existing issues so ON CONFLICT doesn't deduplicate the new spike issue
       (issues, _) <- runTestBg frozenTime tr $ Issues.selectIssues pid Nothing (Just False) Nothing 100 0 Nothing Nothing "24h" [] []
-      forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.id sess.user.id
+      forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.base.id sess.user.id
 
       -- Find an established pattern with stddev > 0
       errRates' <- runTestBg frozenTime tr $ ErrorPatterns.getErrorPatternsWithCurrentRates pid frozenTime
@@ -307,7 +307,7 @@ spec = aroundAll withTestResources do
           -- Acknowledge existing RuntimeException issues to avoid ON CONFLICT dedup
           let sess = Servant.getResponse tr.trSessAndHeader
           (issues, _) <- runTestBg frozenTime tr $ Issues.selectIssues pid Nothing (Just False) Nothing 100 0 Nothing Nothing "24h" [] []
-          forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.id sess.user.id
+          forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.base.id sess.user.id
 
           -- Insert a massive spike (200, well above mean=100 + minAbsoluteDelta=50)
           let spikeTime = addUTCTime 7200 frozenTime
@@ -348,7 +348,7 @@ spec = aroundAll withTestResources do
           -- Acknowledge existing issues to avoid ON CONFLICT dedup
           let sess = Servant.getResponse tr.trSessAndHeader
           (issues, _) <- runTestBg frozenTime tr $ Issues.selectIssues pid Nothing (Just False) Nothing 100 0 Nothing Nothing "24h" [] []
-          forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.id sess.user.id
+          forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.base.id sess.user.id
 
           issuesBefore <- countIssues tr Issues.RuntimeException
           runTestBg spikeTime tr $ BackgroundJobs.detectErrorSpikes pid
@@ -379,7 +379,7 @@ spec = aroundAll withTestResources do
           -- Acknowledge existing issues to avoid ON CONFLICT dedup
           let sess = Servant.getResponse tr.trSessAndHeader
           (issues, _) <- runTestBg frozenTime tr $ Issues.selectIssues pid Nothing (Just False) Nothing 100 0 Nothing Nothing "24h" [] []
-          forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.id sess.user.id
+          forM_ issues \issue -> runTestBg frozenTime tr $ Issues.acknowledgeIssue issue.base.id sess.user.id
           -- Spike both patterns in the same hour bucket
           let concurrentTime = addUTCTime 14400 frozenTime
           forM_ [r1, r2] \r -> do
