[WASM] Add satellite assemblies bundle and hook to register them#20308
Merged
CoffeeFlux merged 1 commit intomono:masterfrom Sep 8, 2020
Merged
[WASM] Add satellite assemblies bundle and hook to register them#20308CoffeeFlux merged 1 commit intomono:masterfrom
CoffeeFlux merged 1 commit intomono:masterfrom
Conversation
monojenkins
requested review from
CoffeeFlux,
lambdageek,
thaystg and
vargaz
as code owners
monojenkins
force-pushed
the
sync-pr-41358-from-runtime
branch
2 times, most recently
from
528623d to
5a58e81
Compare
monojenkins
force-pushed
the
sync-pr-41358-from-runtime
branch
from
5a58e81 to
862435f
Compare
Contributor
|
@monojenkins build failed |
CoffeeFlux
approved these changes
Sep 3, 2020
monojenkins
force-pushed
the
sync-pr-41358-from-runtime
branch
from
862435f to
58a1c77
Compare
This adds a satellite assemblies bundle for WASM and also adds a hook into the driver to be able to register satellite assemblies into the bundle before the runtime is initialized. This allows us to load a satellite assembly by name from the bundle for bundled runtimes. Fixes: dotnet/runtime#39379 cc: @steveisok @marek-safar @lewing
monojenkins
force-pushed
the
sync-pr-41358-from-runtime
branch
from
58a1c77 to
39bb496
Compare
Contributor
|
@monojenkins build failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of dotnet/runtime#41358, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
This adds a satellite assemblies bundle for WASM and also adds a hook into the driver to be able to register satellite assemblies into the bundle before the runtime is initialized. This allows us to load a satellite assembly by name from the bundle for bundled runtimes.
Fixes: dotnet/runtime#39379
cc: @steveisok @marek-safar @lewing