[wasm] Implement support for pinvoke callbacks in the interpeter.#20076
Merged
vargaz merged 5 commits intomono:masterfrom Jul 8, 2020
Merged
[wasm] Implement support for pinvoke callbacks in the interpeter.#20076vargaz merged 5 commits intomono:masterfrom
vargaz merged 5 commits intomono:masterfrom
Conversation
Move the pinvoke table generation code into a new PInvokeTableGenerator.cs file, to be similar to the corresponding code in WasmAppBuilder in dotnet/runtime. NFC.
vargaz
requested review from
BrzVlad,
SamMonoRT,
akoeplinger,
kg,
kjpou1,
lambdageek,
lewing,
marek-safar and
steveisok
as code owners
Contributor
Author
|
Will port to dotnet/runtime manually. |
Contributor
Author
* Modify the tuner to generate a table of trampoline functions which have the same signature as the pinvoke callback methods. * These functions transfer control to the interpreter. * Modify the interpreter/wasm runtime to look up the functions corresponding to the pinvoke callback methods.
vargaz
force-pushed
the
wasm-pinvoke-callbacks
branch
from
f931100 to
f6482ab
Compare
Contributor
Author
|
@monojenkins commit apidiff and csproj |
1 similar comment
Contributor
Author
|
@monojenkins commit apidiff and csproj |
Contributor
Author
|
@monojenkins commit csproj |
Member
|
@BrzVlad could you review interpreter changes |
SamMonoRT
reviewed
Jul 7, 2020
Contributor
Author
|
@monojenkins build failed |
BrzVlad
reviewed
Jul 8, 2020
BrzVlad
approved these changes
Jul 8, 2020
Contributor
Author
|
@monojenkins build failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.