Skip to content

[fsharp] Fix a type inference error introduced by recent changes#13109

Merged
luhenry merged 1 commit intomono:masterfrom
radical:bockbuild-fsharp-fix
Feb 22, 2019
Merged

[fsharp] Fix a type inference error introduced by recent changes#13109
luhenry merged 1 commit intomono:masterfrom
radical:bockbuild-fsharp-fix

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Feb 20, 2019 

@/external/bockbuild/builds/fsharp-fsharp-6624925/src/scripts/fssrgen.fsx(334,28): error FS0041: A unique overload for method 'GetFileNameWithoutExtension' could not be determined based on type information prior to this program point.
A type annotation may be needed. Candidates: System.IO.Path.GetFileNameWithoutExtension(path: System.ReadOnlySpan<char>) : System.ReadOnlySpan<char>, System.IO.Path.GetFileNameWithoutExtension(path: string) : string
[@/external/bockbuild/builds/fsharp-fsharp-6624925/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]

@radical radical mentioned this pull request Feb 20, 2019
Closed
8 tasks
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 20, 2019

/cc @nosami

@radical
[fsharp] Fix a type inference error introduced by recent changes
e8778a3 
```
@/external/bockbuild/builds/fsharp-fsharp-6624925/src/scripts/fssrgen.fsx(334,28): error FS0041: A unique overload for method 'GetFileNameWithoutExtension' could not be determined based on type information prior to this program point.
A type annotation may be needed. Candidates: System.IO.Path.GetFileNameWithoutExtension(path: System.ReadOnlySpan<char>) : System.ReadOnlySpan<char>, System.IO.Path.GetFileNameWithoutExtension(path: string) : string
[@/external/bockbuild/builds/fsharp-fsharp-6624925/src/fsharp/FSharp.Build-proto/FSharp.Build-proto.fsproj]
```
@radical radical force-pushed the bockbuild-fsharp-fix branch from f499b51 to e8778a3 Compare February 21, 2019 16:28
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 21, 2019

@monojenkins build OS X Package

This was referenced Feb 21, 2019
Merged
Merged
nosami
nosami approved these changes Feb 21, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@nosami nosami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should probably try and get this upstreamed.

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 21, 2019

Linux 64 C++ seems to have failed because of:

*** start: wait-helix-tests
make: Entering directory '/mnt/jenkins/workspace/test-mono-pull-request-amd64-cxx/mcs/tools/mono-helix-client'
MONO_PATH="./../../../external/helix-binaries:./../../class/lib/build" /mnt/jenkins/workspace/test-mono-pull-request-amd64-cxx/runtime/mono-wrapper  ./../../class/lib/build/mono-helix-client.exe --wait="db4b202e-d999-459d-b3ca-fc1991212e90"
Waiting for job 'db4b202e-d999-459d-b3ca-fc1991212e90' to finish...
View test results on Mission Control: https://mc.dot.net/#/user/radical/pr~2Fjenkins~2Fmono~2Fmono~2Fmaster~2F/test~2Fmainline-cxx~2F/853d778692258c801d68c64a04bcd2042946ab11
Waiting for work items to finish: Unscheduled: 0, Waiting: 0, Running: 6
Waiting for work items to finish: Unscheduled: 0, Waiting: 0, Running: 6
Waiting for work items to finish: Unscheduled: 0, Waiting: 0, Running: 4
Waiting for work items to finish: Unscheduled: 0, Waiting: 0, Running: 3
Waiting for work items to finish: Unscheduled: 0, Waiting: 0, Running: 3
Job finished, fetching results...
Still processing xunit data from 6 work items. Stay tuned.
Job finished, fetching results...

Tests run: 218272, Passed: 216922, Errors: 0, Failures: 1, Inconclusive: 0
  Not run: 1349, Invalid: 0, Ignored: 0, Skipped: 1349

Job FAILED.
Makefile:18: recipe for target 'wait-for-job-completion' failed
make: Leaving directory '/mnt/jenkins/workspace/test-mono-pull-request-amd64-cxx/mcs/tools/mono-helix-client'
make: *** [wait-for-job-completion] Error 1

.. which isn't related to this PR, IIUC. @akoeplinger Is it ignorable for merging this PR?

@alexischr
Copy link
Copy Markdown
Contributor

alexischr commented Feb 21, 2019

@radical the Failures: 1 in that text is from an actual failure in the helix tests, which are one link further in jenkins. In this case: https://mc.dot.net/#/user/radical/pr~2Fjenkins~2Fmono~2Fmono~2Fmaster~2F/test~2Fmainline-cxx~2F/853d778692258c801d68c64a04bcd2042946ab11/workItem/net_4_x_corlib_xunit-test.dll/analysis/xunit/System.Threading.ThreadPools.Tests.ThreadPoolTests~2FQueueRegisterPositiveAndFlowTest

Either way this is purely a Mac SDK build patch and that's a flake so if the package builds we can merge this

@radical radical mentioned this pull request Feb 21, 2019
Closed
4 tasks
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 22, 2019

OSX Package built successfully. @akoeplinger @alexischr Because of the failing Linux x64 C++ build I can't merge this.

@luhenry luhenry merged commit a4fada3 into mono:master Feb 22, 2019
@radical radical deleted the bockbuild-fsharp-fix branch February 22, 2019 13:41
7c6f434c pushed a commit to NixOS/nixpkgs that referenced this pull request Nov 10, 2020
@moinessim
fsharp41: Add patch to avoid type inference error. (#103223)
24c8927 
mono/mono#13109

Co-authored-by: Moises Nessim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar marek-safar approved these changes

@alexischr alexischr Awaiting requested review from alexischr

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@directhex directhex Awaiting requested review from directhex

@luhenry luhenry Awaiting requested review from luhenry

+1 more reviewer

@nosami nosami nosami approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@radical @alexischr @marek-safar @nosami @luhenry