Skip to content

Update denied assemblies list#13070

Merged
marek-safar merged 2 commits intomono:masterfrom
radical:nuget-denied
Feb 23, 2019
Merged

Update denied assemblies list#13070
marek-safar merged 2 commits intomono:masterfrom
radical:nuget-denied

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Feb 19, 2019

Updating the denied lists for:

  • System.Text.Encoding.CodePages versions 4.5.0 and 4.5.1
  • System.Net.Http versions 4.3.4

Other packages are already up-to-date.

Fixes #12603 .

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 19, 2019

@monojenkins build OS X Package

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 19, 2019

@monojenkins build OS X Extended

@marek-safar
Copy link
Copy Markdown
Member

marek-safar commented Feb 19, 2019

@monojenkins backport 2019-02

@monojenkins monojenkins mentioned this pull request Feb 19, 2019
Merged
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 19, 2019

bockbuild is breaking for gtk-sharp and needs this mono/bockbuild#87 .

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 20, 2019

Waiting for the bump in bockbuild instead - mono/bockbuild#88 .

@radical radical mentioned this pull request Feb 20, 2019
Closed
4 tasks
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 20, 2019

Waiting on bockbuild bump to get the fixes - #13108 .

@radical radical requested a review from luhenry as a code owner February 21, 2019 16:22
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 21, 2019

@monojenkins build OS X Extended

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 21, 2019

@monojenkins build OS X Package

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 21, 2019

Blocked on #13109 .

@radical
[nuget] Add new versions of System.Text.Encoding.CodePages ..
e5760b6 
.. to the list of denied assemblies. Added:

- `4.5.0`
- `4.5.1`

Fixes issue mono#12603 .
@radical
[nuget] Add new versions of System.Net.Http
13b6266 
.. to the list of denied assemblies. Added `4.3.4`.

Prompted by issue mono#12603 .
@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 22, 2019 •
edited
Loading

All the failing tests have nothing to do with this PR. Details below. @akoeplinger @marek-safar Could you please merge this PR?

Linux ARMv7, Linux AArch64 Coop Suspend, Linux ARMv7:

HttpWebRequestTest.Sync
WebClientTest.DownloadTwice

Linux AArch64 FullAOT:
/../../class/lib/testing_aot_full/tests/testing_aot_full_System_test.dll.testing_aot_full_System_test.dll.crash

Linux AArch64 Interpreter:

10:33:22 Errors and Failures:
10:33:22 
10:33:22 1) DownloadTwice (MonoTests.System.Net.WebClientTest.DownloadTwice)
10:33:22    System.Net.WebException : The remote server returned an error: (503) Service Unavailable.
10:33:22   at System.Net.HttpWebRequest.GetResponseFromData (System.Net.WebResponseStream stream, System.Threading.CancellationToken cancellationToken) [0x00146] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/mcs/class/System/System.Net/HttpWebRequest.cs:1101 
10:33:22   at System.Net.HttpWebRequest.RunWithTimeoutWorker[T] (System.Threading.Tasks.Task`1[TResult] workerTask, System.Int32 timeout, System.Action abort, System.Func`1[TResult] aborted, System.Threading.CancellationTokenSource cts) [0x000e8] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/mcs/class/System/System.Net/HttpWebRequest.cs:956 
10:33:22   at System.Net.HttpWebRequest.GetResponse () [0x0000f] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/mcs/class/System/System.Net/HttpWebRequest.cs:1218 
10:33:22   at System.Net.WebClient.GetWebResponse (System.Net.WebRequest request) [0x00000] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/external/corefx/src/System.Net.WebClient/src/System/Net/WebClient.cs:249 
10:33:22   at System.Net.WebClient.DownloadBits (System.Net.WebRequest request, System.IO.Stream writeStream) [0x000e6] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/external/corefx/src/System.Net.WebClient/src/System/Net/WebClient.cs:850 
10:33:22   at System.Net.WebClient.DownloadFile (System.Uri address, System.String fileName) [0x00088] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/external/corefx/src/System.Net.WebClient/src/System/Net/WebClient.cs:329 
10:33:22   at System.Net.WebClient.DownloadFile (System.String address, System.String fileName) [0x00000] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/external/corefx/src/System.Net.WebClient/src/System/Net/WebClient.cs:308 
10:33:22   at MonoTests.System.Net.WebClientTest.DownloadTwice () [0x0000b] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/mcs/class/System/Test/System.Net/WebClientTest.cs:38 
10:33:22   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
10:33:22   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in /home/builder/jenkins/workspace/test-mono-pull-request-interpreter-aarch64/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:391 
10:33:22 
10:33:22 
10:33:22 Flaky Test Retries:
10:33:22 
10:33:22 FAIL (0 passes/5 fails): DownloadTwice (MonoTests.System.Net.WebClientTest.DownloadTwice)

@radical
Copy link
Copy Markdown
Member Author

radical commented Feb 22, 2019

@marek-safar Does this need to be backported to any other branches?

@marek-safar
Copy link
Copy Markdown
Member

marek-safar commented Feb 23, 2019

@radical no

@marek-safar marek-safar merged commit 6df26e8 into mono:master Feb 23, 2019
@radical radical deleted the nuget-denied branch February 23, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar marek-safar approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@lambdageek lambdageek Awaiting requested review from lambdageek

@vargaz vargaz Awaiting requested review from vargaz

@luhenry luhenry Awaiting requested review from luhenry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mono throws exception with text GetCPInfoExW opening binary file

2 participants

@radical @marek-safar