This repository was archived by the owner on Aug 8, 2024. It is now read-only.
[bockbuild] Add gtk-sharp patch to fix build with mcs#87
Closed
radical wants to merge 1 commit intomono:masterfrom
Closed
[bockbuild] Add gtk-sharp patch to fix build with mcs#87radical wants to merge 1 commit intomono:masterfrom
radical wants to merge 1 commit intomono:masterfrom
Conversation
Recent addition of C#8 features to mcs possibly broke this: ``` mcs -out:WidgetViewer.exe -r:../../glib/glib-sharp.dll -r:../../pango/pango-sharp.dll -r:../../atk/atk-sharp.dll -r:../../gdk/gdk-sharp.dll -r:../../gtk/gtk-sharp.dll ./TestCheckButton.cs ./TestColorSelection.cs ./TestRadioButton.cs ./TestRange.cs ./TestStatusbar.cs ./TestDialog.cs ./TestFlipping.cs ./TestSizeGroup.cs ./TestCombo.cs ./TestComboBox.cs ./WidgetViewer.cs ./TestCombo.cs(17,14): warning CS0612: `Gtk.Combo' is obsolete ./TestRange.cs(35,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(35,13): error CS0030: Cannot convert type `Gtk.HScale' to `System.Range' ./TestRange.cs(42,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(42,13): error CS0030: Cannot convert type `Gtk.HScrollbar' to `System.Range' ./TestRange.cs(62,6): error CS0104: `Range' is an ambiguous reference between `System.Range' and `Gtk.Range' @/external/bockbuild/stage/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error) @/external/bockbuild/builds/gtk-sharp-None/sample/test/../../gtk/gtk-sharp.dll (Location of the symbol related to previous error) ./TestRange.cs(62,13): error CS0030: Cannot convert type `Gtk.VScale' to `System.Range' ``` This is because the compiler is resolving `Range` in the test as `System.Range` instead of `Gtk.Range`, so we disambiguate it. /cc @marek-safar
marek-safar
approved these changes
Feb 19, 2019
Member
Author
|
Testing this with mono/mono#13076 . |
Member
Author
|
@alexischr This fixes one part of the build! This needs to be merged for merging mono/mono#13076 which fixes the mono build completely. |
Contributor
|
Why not PR against 2-12 branch and update the ref? |
Member
Author
|
@Therzok You are correct. I was trying to test and ensure that it works fine, in a longer chain of interdependent commits+PRs. I have opened a new PR now for gtk-sharp. Hopefully, that can be merged quickly and I can bump the ref in bockbuild. |
Member
Author
|
err.. the PR: mono/gtk-sharp#263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent addition of C#8 features to mcs possibly broke this:
This is because the compiler is resolving
Rangein the test asSystem.Rangeinstead of
Gtk.Range, so we disambiguate it./cc @marek-safar