This repository was archived by the owner on Jan 14, 2021. It is now read-only.
[FinallyDelegate] make key for lookupTable actually unique
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attributes like `[TestCase]` execute the same test method multiple times, therefore there could be a clash in `lookupTable` when adding more elements to it.
akoeplinger
suggested changes
Feb 12, 2018
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
I'm not convinced we need this change (see Slack convo).
| public void Set (TestExecutionContext context, long startTicks, TestResult result) { | ||
| var frame = new Tuple<TestExecutionContext, long, TestResult>(context, startTicks, result); | ||
|
|
||
| var name = result.FullName + "_" + result.Test.FullName + "_" + result.GetHashCode (); |
Member
There was a problem hiding this comment.
result.FullName and result.Test.FullName have the same value for parameterized tests (and it correctly includes the parameter value).
Additionally you're not changing the retrieval logic in nevermind, misread.HandleUnhandledExc () so this would fail when an exception does occur.
…hout doubt unique
akoeplinger
approved these changes
Feb 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes like
[TestCase]execute the same test method multipletimes, therefore there could be a clash in
lookupTablewhen addingmore elements to it.