chore: move main linting to oxlint (@miodec) by Miodec · Pull Request #7144 · monkeytypegame/monkeytype

Miodec · 2025-11-23T22:52:22Z

main linting is now done by oxlint. eslint remains for linting json files in the frontend (until oxlint adds support)
move type checking to the lint step (with --type-check)
this improves performance by removing a duplicated typescript parse task (instead of parsing for linting then again for type checking, it parses once for both)
add a lint-fast npm script to get some fast fail behavior. it simply lints with no type information
oxc plugins are still in preview, so the custom plugin that checks for __testing usage outside of tests runs outside the main linting job until performance is improved
fixes some type issues (and config issues) that were not visible due to a missing type check on some files. now type checking will run on every file that is linted
split up oxc config for easier management

seeing around 3x improvement in type aware linting

socket-security · 2025-11-23T22:52:58Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	etag@1.8.1
	supertest@7.1.4
	typescript@5.9.3
	@eslint/json@0.14.0

View full report

github-actions · 2025-12-15T13:44:35Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copilot

Pull request overview

This PR migrates the project's main linting infrastructure from ESLint to oxlint for improved performance, achieving approximately 3x faster type-aware linting. ESLint is retained solely for linting JSON files in the frontend until oxlint adds native support.

Key Changes:

Migrated to oxlint 1.33.0 with oxlint-tsgolint 0.9.0 for type-aware linting
Consolidated type checking into the lint step using --type-check flag to eliminate duplicate TypeScript parsing
Removed the standalone @monkeytype/eslint-config package
Split oxlint configuration into modular files for better maintainability
Added lint-fast script for quick linting without type information
Updated all disable comments from eslint-disable to oxlint-disable syntax
Fixed previously hidden type issues exposed by comprehensive type checking

Reviewed changes

Copilot reviewed 111 out of 112 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
turbo.json	Added lint-fast task configuration
pnpm-lock.yaml	Updated dependencies: removed eslint from root/backend/packages, added oxlint 1.33.0 and oxlint-tsgolint, upgraded frontend eslint to 9.39.1
package.json	Updated root lint scripts to use lint-fast variants, removed eslint dependency
packages/oxlint-config/*	Split configuration into modular files (enabled.jsonc, disabled.jsonc, ts-enabled.jsonc, etc.) and added custom plugin support
packages/eslint-config/*	Removed entire package as it's no longer needed
frontend/*	Migrated to new eslint.config.js for JSON-only linting, updated disable comments, fixed type issues
backend/*	Updated lint scripts, migrated disable comments, fixed type issues in DAL and controllers
.github/workflows/monkey-ci.yml	Added lint-fast step before full lint for faster feedback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

frontend/.oxlintrc.json

frontend/src/ts/ape/adapters/ts-rest-adapter.ts

github-actions · 2025-12-15T14:31:58Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

socket-security · 2025-12-15T16:03:08Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `safer-buffer` is 94.0% likely obfuscated Confidence: 0.94 Location: Package overview From: pnpm-lock.yaml → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Miodec added 17 commits October 31, 2025 20:14

plugin

12de365

brrr

01012ec

update rule

04e3279

update comment

ee4f0d1

yeet eslint

7a0908b

root dep

bec7945

move to dev

303042b

i

a4ce60c

Merge branch 'master' into oxc-no-testing-access

3eeffee

ignore in tests

9e6266d

remove test code

3be2a92

Merge branch 'master' into tsgolint

95b081f

cleanup

e5b234f

refactor

7548fbb

Merge branch 'oxc-no-testing-access' into tsgolint

aaa1bbf

pnpm i

d787450

move

08d2e46

monkeytypegeorge added backend Server stuff frontend User interface or web stuff packages Changes in local packages labels Nov 23, 2025

Miodec added 4 commits November 24, 2025 00:04

disable ts rules in base config

b2dda96

missing typeaware

d27f7b1

move test overrides to root config

175d2b2

remove exlint from readme

eb944b7

monkeytypegeorge added the docs Related to Markdown files and documentation label Nov 23, 2025

Miodec added 2 commits November 24, 2025 00:32

revert

1a2cf67

revert

e317613

Miodec requested a review from fehmer November 23, 2025 23:56

github-actions bot added the waiting for review Pull requests that require a review before continuing label Nov 23, 2025

upgrade packages, enable rules, fix errors

bb39fc5

Miodec marked this pull request as ready for review December 15, 2025 13:40

github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 15, 2025

Merge branch 'master' into tsgolint

d0e8eb8

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Dec 15, 2025

Miodec added the force-ci Force CI to run on draft PRs label Dec 15, 2025

Merge branch 'master' into tsgolint

a726a8c

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 15, 2025

Miodec requested a review from Copilot December 15, 2025 13:55

github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 15, 2025

Copilot started reviewing on behalf of Miodec December 15, 2025 14:02 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

frontend/.oxlintrc.json Outdated Show resolved Hide resolved

frontend/src/ts/ape/adapters/ts-rest-adapter.ts Outdated Show resolved Hide resolved

fixes

585793e

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Dec 15, 2025

Miodec added 2 commits December 15, 2025 15:36

Merge branch 'master' into tsgolint

5629fdb

fix tests

bf95dea

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 15, 2025

fehmer previously approved these changes Dec 15, 2025

View reviewed changes

revert one rule

ce6a1b3

Miodec dismissed fehmer’s stale review via ce6a1b3 December 15, 2025 15:51

Miodec added 2 commits December 15, 2025 16:59

Merge branch 'master' into tsgolint

7a229f4

fix

229dd08

fix

2ed547c

Miodec merged commit a067a32 into master Dec 15, 2025
13 checks passed

Miodec deleted the tsgolint branch December 15, 2025 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: move main linting to oxlint (@miodec)#7144

chore: move main linting to oxlint (@miodec)#7144
Miodec merged 64 commits intomasterfrom
tsgolint

Miodec commented Nov 23, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

socket-security bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Miodec commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025

Uh oh!

socket-security bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Miodec commented Nov 23, 2025 •

edited

Loading

socket-security bot commented Nov 23, 2025 •

edited

Loading

socket-security bot commented Dec 15, 2025 •

edited

Loading