Changes to enable 1904-based dates#72
Conversation
| } catch(RuntimeException e) { | ||
| f.delete(); | ||
| throw e; | ||
| private static final Logger log = LoggerFactory.getLogger(StreamingWorkbookReader.class); |
There was a problem hiding this comment.
It's really hard to tell what changed here because it looks like you re-indented the entire file and re-ordered the methods. Can you please update this to use two-space indents and keep the original ordering?
There was a problem hiding this comment.
Hurm, it appears my IDE got overly aggressive. I've reverted the change and reapplied the fix. We should be good to go now.
| } | ||
| } | ||
| @Test | ||
| public void testGetDateCellValue1904() throws Exception { |
There was a problem hiding this comment.
Thanks for including a test case!
There was a problem hiding this comment.
Wouldn't dream of offering a pull request without one
monitorjbl
left a comment
monitorjbl
left a comment
There was a problem hiding this comment.
Just need to clean up the StreamingWorkbookReader class and I think this will be good to merge.
|
Awesome, thanks. Whenever you have a chance to get it up on Maven Central, that would help me out a lot |
2 participants
No description provided.