Basic implementation for getCell with MissingCellPolicy.#67
Merged
monitorjbl merged 4 commits intomonitorjbl:masterfrom Jan 26, 2017
waxxxd:master
Merged
Basic implementation for getCell with MissingCellPolicy.#67monitorjbl merged 4 commits intomonitorjbl:masterfrom waxxxd:master
monitorjbl merged 4 commits intomonitorjbl:masterfrom
waxxxd:master
Conversation
Owner
|
Needs a unit test, but the code looks good. Add a test and I'll be good to merge this. |
Contributor
Author
|
Will spin one up. EDIT: Will take a while, busy. |
-Unit tests for cummulative changes.
monitorjbl
approved these changes
Jan 26, 2017
| } | ||
|
|
||
| @Test | ||
| public void testShouldReturnNullForMissingCellPolicy_RETURN_BLANK_AS_NULL() throws Exception { |
Contributor
Author
|
Literally pushed another line for the JUnit 10 seconds after the approval. New pull request? |
Owner
|
Sure, that's fine. What you had looked alright to me, but more tests are always good to have. |
Contributor
Author
|
Is just a negative confirmation without the missing cell policy, before the positive with the missing cell policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve the issues experienced in Issue #33 .