Implemented the Row.getZeroHeight and Sheet.IsColumnHidden methods#48
Merged
monitorjbl merged 3 commits intomonitorjbl:masterfrom Aug 4, 2016
Merged
Implemented the Row.getZeroHeight and Sheet.IsColumnHidden methods#48monitorjbl merged 3 commits intomonitorjbl:masterfrom
monitorjbl merged 3 commits intomonitorjbl:masterfrom
Conversation
| private final StylesTable stylesTable; | ||
| private final XMLEventReader parser; | ||
| private final DataFormatter dataFormatter = new DataFormatter(); | ||
| private final Set<Integer> hiddenColumns = new HashSet<>(); |
Owner
There was a problem hiding this comment.
I'm not sure why this needs to be here. This information only applies to Rows, correct?
Contributor
Author
There was a problem hiding this comment.
No, this does not apply to rows, this is in support of the org.apache.poi.ss.usermodel.Sheet.isColumnHidden(int columnIndex) method
Owner
There was a problem hiding this comment.
Ah, I see. I thought that method was on Row. Looks fine to me then.
Owner
|
Can you add a quick unit test for this? Once that's in, I'm good to merge this. |
Owner
|
Thanks! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.