fixed formula reference issues#118
Merged
monitorjbl merged 1 commit intomonitorjbl:masterfrom Jul 13, 2018
apixandru:master
Merged
fixed formula reference issues#118monitorjbl merged 1 commit intomonitorjbl:masterfrom apixandru:master
monitorjbl merged 1 commit intomonitorjbl:masterfrom
apixandru:master
Conversation
Contributor
Author
|
anyone alive in here? :) |
Owner
|
Sorry, started a new job and I haven't had much time to review these PRs. I agree that this will need a version bump. I'm going to hold off merging this until I can get the other changes released. |
Contributor
Author
|
No worries, I just wanted to make sure that someone had a chance to look over this. I have rebased the change on top of the new code changes to solve the conflicts. |
|
Any update on when this change can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes two issues
In my opinion, since this is likely to cause a regression on people expecting the old behavior, It would probably be a good idea to increment the major version or at least the minor one.