Optimized based on output from profiler on large sheets#112
Merged
monitorjbl merged 1 commit intomonitorjbl:masterfrom Sep 30, 2017
Merged
Conversation
Owner
|
Interesting, will have to confirm after merging. Regardless, deferring the cost of number parsing until they're used seems like a good idea. |
Owner
|
I'm not seeing the massive improvement you did with my 250k row test sheet. It is roughly 10% faster, so there's definitely an improvement but it's not nearly as marked as what you saw. |
Author
|
If you’re interested, I’ll make my test set available. |
Owner
|
If it's not private data, that would be very helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across a performance issue with large spreadsheets, and investigated this using the YourKit profiler.
Two bottlenecks that could be addressed were identified: one is heavy use of a regexp in a function used to split a cell reference string, and the other because of unnecessary formatting of a value, where the formatting could be deferred until if/when the value was actually used.
With my set of files, total processing time went from 944 to 525 seconds with these changes included.
Note to reviewer: the change from regexp to a simplified method when splitting the cell reference works for all tests in the project, and on my testset. If I missed a format that could occur here, please let me know and I will add tests and update the code.