check_users: improve performance #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch use the utxent function family to collect the user data. It improve the check speed. Need a system conforming to POSIX.1-2001.
ghost
assigned
Member
|
We pulled the commit, thanks. |
This was referenced Sep 24, 2013
sni
added a commit
to sni/monitoring-plugins
that referenced
this pull request
Nov 4, 2024
somehow check_disk crashes on opensuse 15 sp6:
Core was generated by `.../monitoring-plugins/check_disk -w 80% -c 90% -p /'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007ffff74ca6b6 in __strlen_sse2 () from /lib64/libc.so.6
(gdb) bt
#0 0x00007ffff74ca6b6 in __strlen_sse2 () from /lib64/libc.so.6
monitoring-plugins#1 0x00007ffff7f81aed in dopr (buffer=0x0, maxlen=0, format=0x40a607 "%s inode=-)%s;", args_in=0x7fffffffda30) at lib/snprintf.c:712
monitoring-plugins#2 0x00007ffff7f82c6c in smb_vsnprintf (str=0x0, count=0, fmt=0x40a5f0 "%s%s %s %llu%s (%.1f%%", args=0x7fffffffda30) at lib/snprintf.c:1197
monitoring-plugins#3 0x00007ffff7f82d79 in vasprintf (ptr=0x7fffffffdba8, format=0x40a5f0 "%s%s %s %llu%s (%.1f%%", ap=0x7fffffffda78) at lib/snprintf.c:1232
monitoring-plugins#4 0x0000000000405cf9 in xvasprintf (strp=0x7fffffffdba8, fmt=<optimized out>, ap=<optimized out>) at utils.c:563
monitoring-plugins#5 0x0000000000405db7 in xasprintf (strp=strp@entry=0x7fffffffdba8, fmt=fmt@entry=0x40a5f0 "%s%s %s %llu%s (%.1f%%") at utils.c:575
monitoring-plugins#6 0x0000000000402d9f in main (argc=<optimized out>, argv=<optimized out>) at check_disk.c:434
(gdb) f 6
monitoring-plugins#6 0x0000000000402d9f in main (argc=<optimized out>, argv=<optimized out>) at check_disk.c:434
434 xasprintf (&output, "%s%s %s %llu%s (%.1f%%",
(gdb) p flag_header
$1 = 0x1cbf0 <error: Cannot access memory at address 0x1cbf0>
(gdb)
initializing flag_header helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch use the utxent function family to collect the user data. It improve the check speed.
Need a system conforming to POSIX.1-2001.
Tested only on Debian Squeeze x86_64.
Already sent: ID: 3373486
http://sourceforge.net/tracker/?func=detail&atid=397599&aid=3373486&group_id=29880