More renaming due to MySQL name chances #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to MySQL changing several term in Version 8.0.22 the way to determine the status of replicas has changed. To adapt to these changes in a517dc6 check_mysql was modified to adapt to different versions. Some parts were missed though which results in failures to detect the replica status properly. This parts should be contained in this commit.
Member
|
Hi @RincewindsHat, patching 2.4.0 results into compiling issues: Cheers, Jan |
Member
|
@RincewindsHat I've adjusted my patchset to use slave_io_field and slave_sql_field for 2.4.0. My patchset you can find at https://salsa.debian.org/nagios-team/monitoring-plugins/-/blob/trixie/debian/patches/25_check_mysql_replica |
Member
@RincewindsHat Joe is reporting the latest patchset is working. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to MySQL changing several term in Version 8.0.22 the way to determine the status of replicas has changed.
To adapt to these changes in a517dc6 check_mysql was modified to adapt to different versions. Some parts were missed though which results in failures to detect the replica status properly.
This parts should be contained in this commit.
Should also fix some of the problems discussed in #2068
Ping @waja therefore. these changes have to added to the maintenance branch