Skip to content

Conversation

@RincewindsHat
Copy link
Member

@RincewindsHat RincewindsHat commented May 18, 2025

Finally the big refactor check_icmp is coming to a close.

Main points:

  • Proper IPv6 + IPv4-dualstack functionality
  • far less global variables
  • countless renamings.

fixes #2121

@RincewindsHat RincewindsHat force-pushed the refactor/check_icmp branch from 4da4396 to 0f8690c Compare June 9, 2025 10:42
The timeout option was redundant in that the runtime
of check_icmp was always limited by the input parameters
and therefore timeout gets removed with this commit to
avoid that confusion.

The rest of the signal handlings was removed too, since
the added complexity does not provide sufficient returns.
If check_icmp gets a signal, it now dies like most other
programs instead of trying to save some things and return a
(arguably wrong) result.
@RincewindsHat RincewindsHat marked this pull request as ready for review June 20, 2025 09:12
@RincewindsHat RincewindsHat merged commit b8580c1 into monitoring-plugins:master Jun 20, 2025
7 checks passed
@RincewindsHat RincewindsHat deleted the refactor/check_icmp branch June 20, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_rta_multi/check_icmp: Multiple targets from a Host with multiple addresses are indistinguishable

1 participant