Do not explicitely disable IPv6 in the CI #2123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
It was disabled because of infrastructure issues at GitHub. |
Member
Author
|
Thanks @waja, that makes sense. Was it necessary though to deactivate compilation of IPv6 support completely? Anyways, the tests seem to run properly. I guess we can continue with these changes then? |
Member
|
I don't remember for the exact reason anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously IPv6 functionality was explicitely disabled in the Github CI,
although it is not clear to me why that was the case,
since IPv6 was not used there but there is no good reason
to not compile the functionality at all.
This should fix some of the problems with #2115