change error message for missing certificate #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old error message is quite similar to the openssl `failed to retrieve issuer certificate` and can mislead users to troubleshooting certificate stores. The new message should be distinct enough to make it clear to users that this is not a problem raised by the underlying SSL implementation, but a problem inside monitoring-plugins.
RincewindsHat
approved these changes
Mar 17, 2025
Member
RincewindsHat
left a comment
RincewindsHat
left a comment
There was a problem hiding this comment.
Thanks, that sounds reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old error message is quite similar to the openssl
failed to retrieve issuer certificateand can mislead users to troubleshooting certificate stores.The new message should be distinct enough to make it clear to users that this is not a problem raised by the underlying SSL implementation, but a problem inside monitoring-plugins.
This change is triggered by a problem I have in our infrastructure that leads to missing certificates, where I mistook the error message as coming from openssl, which turned out to be the wrong direction. Then again today I went down the same rabbit hole until I remembered that the problem was outside the openssl certificate stores.
Hopefully I will manage to build a reproducible problem to demonstrate the actual problem that caused me to see this error message, or maybe I'll even get it fixed myself.