-
Notifications
You must be signed in to change notification settings - Fork 284
Check mysql replica check #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check mysql replica check #2068
Conversation
This commit adds an option "check-replica" to check_mysql which replaces "check-slave" (which still works). The changes are introduced to follow the naming scheme of MySQL/MariaDB, since this was changed there in version 8 (MySQL) or 10.5.1 (MariaDB).
8c97da5 to
c08e2bc
Compare
|
@seb4web This should fix your problem. |
|
I'm trying to figure out how to get ahold of this patch... we're attempting to run MySQL 8.4 on an Alma 9 server and encountering this issue. Has there been a release containing this patch yet? I could also build my own nagios-plugins RPMs from scratch if I need... but I wasn't sure how to make sure I'm pulling in this changeset. Any advice? EDIT: I tried building from the 2.4.12 src.rpm, but it doesn't appear to contain this patch either. I tried to patch it in myself by hand, but it seems to depend on some sort of a deeper reorg involving files like threshold.h and perfdata.h. |
|
Hi @abaddononion, Currently it might be difficult to cherry-pick this patch, since I am refactoring a lot of stuff and there are a lot of intermixed changes. You could use the |
I see. so even if you release a new "Monitoring Plugins" package, that won't help me until the fork catches up... well that's problematic, for sure. I guess I'm going to have to write my own patch for the nagios-plugins package in the meantime and just go off-grid, because otherwise it seems like this is going to be a long wait, and I'm supposed to go to production with MySQL 8.4 in about a month. Thanks for the feedback. |
|
@RincewindsHat This isses has landed into the Debian BTS: https://bugs.debian.org/1116027 As I would love to fix it in Debian stable, as it might be EOLed 5 years in the future, this patch set is so large, that it is very unlikely to get approved by the Debian Release Managers. Is there a way to strip this down to a minimum? |
|
@waja most of the changes are formatting, the essentials are not that big. If I find the time I can try to build a minimalist version of this. |
hi @RincewindsHat, there is feedback from the BTS:
I think beside the "sever" typo, there seems to be a different issue. :) |
|
well, should have tested that against a real MySQL(tm) server. That also needs repair in the |
The latest patchset seems to result into: |
@RincewindsHat it looks like the issue isn't solved in 2.4.0 yet and I also don't know, if that is working in master. We don't have a test against a mysql cluster instance in our test pipelines. :) |
fixes #2060
This patchset contains two parts.
convention for MySQL (and MariaDB too).
Another cli option
--check-replicagets introduced andcheck_slavemarked as deprecated(although it will still work for now)
on the result queries for replicas or for "slaves" if the version is older and does not
provide that syntax