Add dontfrag / random to fping check #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RincewindsHat
requested changes
Nov 6, 2024
Member
RincewindsHat
left a comment
RincewindsHat
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Looks like I can't hurt, I would like to merge it in principle.
But right now, there is at least one problem I would like you to fix.
Support the dont fragment and randomise packet data options for check_fping
Firstyear
force-pushed
the
20241006-fping-dont-frag
branch
from
8440ca9 to
88d9917
Compare
RincewindsHat
approved these changes
Nov 7, 2024
Member
RincewindsHat
left a comment
RincewindsHat
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2040 - this adds dontfrag and random flags to the check_fping tool.