Skip to content

Cleanup for some more plugins #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RincewindsHat merged 131 commits into from
Oct 31, 2024
Merged

Cleanup for some more plugins #2035

RincewindsHat merged 131 commits into from
Oct 31, 2024

Conversation

@RincewindsHat
Copy link
Member

@RincewindsHat RincewindsHat commented Oct 31, 2024 •
edited
Loading

On several plugins:

  • clang-format
  • update copyright
  • some linter fixes

@RincewindsHat
check_by_ssh: clang-format
9f1ec43
@RincewindsHat
check_by_ssh: Copyright update
744568f
@RincewindsHat
check_by_ssh: do not export local symbols
ba47cca
@RincewindsHat
check_by_ssh: linter fixes
060bd01
@RincewindsHat
check_cluster: clang-format
80ec3f0
@RincewindsHat
check_cluster: Copyright update
a30f0c6
@RincewindsHat
check_cluster: do not export local symbols
ebb453f
@RincewindsHat
check_cluster: linter fixes
289f07d
@RincewindsHat
check_curl: clang-format
80f07ff
@RincewindsHat
check_curl: Update copyright
367c4f8
@RincewindsHat
check_curl: do not export local variables and remove unused ones
7334812
@RincewindsHat
check_curl: Linter fixes
fde8e9c
@RincewindsHat
check_dbi: clang-format
c413037
@RincewindsHat
check_dbi: Update copyright
267c668
@RincewindsHat
check_dbi: do not export local symbols
981f1d5
@RincewindsHat
check_dbi: linter fixes
79d7f40
@RincewindsHat
check_dig: clang-format
904d1ef
@RincewindsHat
check_dig: do not export local symbols
f0d7803
@RincewindsHat
check_dig: Linter fixes
acb19fe
@RincewindsHat
check_disk: clang-format
25e0c67
@RincewindsHat
check_disk: Update copyright
78aa691
@RincewindsHat
check_dig: Update copyright
e57e86a
@RincewindsHat
check_disk: Linter fixes
08526fd
@RincewindsHat
check_dns: clang-format
499c0a0
@RincewindsHat
check_dns: do not export local variables
702dc59
@RincewindsHat
check_dns: Linter fixes
4f34506
@RincewindsHat
check_dns: update copyright
078e9b9
@RincewindsHat
check_dummy: clang-format
31133c7
@RincewindsHat
check_dummy: update copyright
1633fd7
@RincewindsHat
check_dummy: do not export local symbols
5f2ae6d
@RincewindsHat
runcmd.c: clang-format
629571a
@RincewindsHat
runcmd.c: update copyright
4ca5696
@RincewindsHat
netuils.c: clang-format
daecd2f
@RincewindsHat
netutils.c: update copyright
e353337
@RincewindsHat
sslutils.c: clang-format
8c937fb
@RincewindsHat
sslutils.c: update copyright
d32adb6
@RincewindsHat
urlize.c: clang-format
cadc940
@RincewindsHat
urlize.c: update copyright
9c9d7a0
@RincewindsHat
plugins/utils.c: clang-format
dde0e51
@RincewindsHat
plugins/utils.c: update copyright
08d9932
@RincewindsHat
check_ide_smart: clang-format again
bb6e5da
@RincewindsHat
check_nwstat: clang-format
e334857
@RincewindsHat
check_nwstat: update copyright
ac3cb0b
@RincewindsHat
check_overcr: clang-format
3b1ffd9
@RincewindsHat
check_overcr: update copyright
d08ac70
@RincewindsHat
check_nt: clang-format
520617e
@RincewindsHat
check_nt: update copyright
fcfa439
@RincewindsHat
check_radius: update copyright
66655d5
@RincewindsHat
check_ldap: update copyright
86f1703
@RincewindsHat
check_apt: update copyright
2ceeada
@RincewindsHat
check_mysql: update copyright
de5709b
@RincewindsHat
check_procs: update copyright
3962ab9
@RincewindsHat
check_smtp: update copyright
41b0b95
@RincewindsHat
check_ntp: update copyright
ffa1d68
@RincewindsHat
check_ssh: update copyright
611b33a
@RincewindsHat
urlize: update copyright
f0c6157
@RincewindsHat
check_http: update copyright
8955f56
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 31, 2024
View reviewed changes
plugins/check_ping.c
(sscanf(buf,"%*d packets transmitted %*d received, +%*d errors, %d%% packet loss%n",&pl,&match) && match) ||
(sscanf(buf,"%*[^(](%d%% %*[^)])%n",&pl,&match) && match)
)
if ((sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d errors, %d%% packet loss%n", &pl, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf,"%*[^(](%d%% %*[^)])%n",&pl,&match) && match)
)
if ((sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d errors, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
)
if ((sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d errors, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
if ((sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d errors, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d packets received, %d%% packet loss%n", &pl, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf, "%*d packets transmitted, %*d packets received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d received, +%*d duplicates, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d packets received, %d%% packet loss%n", &pl, &match) && match) ||
(sscanf(buf, "%*d packets transmitted, %*d packets received, %d%% loss, time%n", &pl, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf, "round-trip min/avg/max/mdev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip min/avg/max/sdev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip min/avg/max/stddev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip min/avg/max/std-dev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf, "round-trip min/avg/max/sdev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip min/avg/max/stddev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip min/avg/max/std-dev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip (ms) min/avg/max = %*f/%f/%*f%n", &rta, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf, "round-trip min/avg/max/stddev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip min/avg/max/std-dev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip (ms) min/avg/max = %*f/%f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip (ms) min/avg/max/stddev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf, "round-trip min/avg/max/std-dev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip (ms) min/avg/max = %*f/%f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip (ms) min/avg/max/stddev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "rtt min/avg/max/mdev = %*f/%f/%*f/%*f ms%n", &rta, &match) && match) ||

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
plugins/check_ping.c
(sscanf(buf, "round-trip (ms) min/avg/max = %*f/%f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "round-trip (ms) min/avg/max/stddev = %*f/%f/%*f/%*f%n", &rta, &match) && match) ||
(sscanf(buf, "rtt min/avg/max/mdev = %*f/%f/%*f/%*f ms%n", &rta, &match) && match) ||
(sscanf(buf, "%*[^=] = %*fms, %*[^=] = %*fms, %*[^=] = %fms%n", &rta, &match) && match))

Check failure

Code scanning / CodeQL

Incorrect return-value check for a 'scanf'-like function High

The result of scanf is only checked against 0, but it can also return EOF.
@RincewindsHat RincewindsHat merged commit b1d260a into monitoring-plugins:master Oct 31, 2024
6 of 7 checks passed
@RincewindsHat RincewindsHat deleted the cleanup/rest-of-plugins branch October 31, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RincewindsHat