fix check_curl: OpenSSL SSL_read: error:0A000126:SSL routines::unexpe… #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sni
force-pushed
the
fix_check_curl_ssl_eof
branch
from
70ba033 to
d3e9a8e
Compare
sni
force-pushed
the
fix_check_curl_ssl_eof
branch
2 times, most recently
from
de7e579 to
9b4e131
Compare
Contributor
Author
|
Probably totally unrelated to my changes, will retry again tomorrow. fedory rawhide is broken: Maybe we should handle rawhide like debian testing and keep it out of our required test suites but put them in a separate action which maybe runs once a month to make sure we get notified if futur release might break something. |
sni
force-pushed
the
fix_check_curl_ssl_eof
branch
3 times, most recently
from
da9f09a to
52fd391
Compare
Contributor
Author
|
waiting for #2023 |
sni
force-pushed
the
fix_check_curl_ssl_eof
branch
3 times, most recently
from
749e505 to
302efa1
Compare
…cted eof while reading, errno 0
using check_curl on a probably embedded device responding as 'Server: GoAhead-Webs'
%> check_curl -H ... -S -vvv
> GET / HTTP/1.1
Host: ...
User-Agent: check_curl/v2.4.0 (monitoring-plugins 2.4.0, libcurl/7.76.1 OpenSSL/3.0.7 zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.1 (+libidn2/2.3.0) libssh/0.10.4/openssl/zlib nghttp2/1.43.0)
Accept: */*
Connection: close
* Mark bundle as not supporting multiuse
* HTTP 1.0, assume close after body
< HTTP/1.0 302 Redirect
< Server: GoAhead-Webs
< Date: Tue Mar 26 17:57:16 2019
< Cache-Control: no-cache, no-store, must-revalidate,private
< Pragma: no-cache
< Expires: 0
< Content-Type: text/html
< X-Frame-Options: sameorigin
< X-XSS-Protection: 1; mode=block
< X-Content-Type-Options: nosniff
< Location: https://...
<
* OpenSSL SSL_read: error:0A000126:SSL routines::unexpected eof while reading, errno 0
* Closing connection 0
reading the discussion on openssl/openssl#22690 suggest to set the option SSL_OP_IGNORE_UNEXPECTED_EOF
which makes check_curl behave like check_http at this point.
Since this is a rather new flag, fencing it in ifdefs.
And since there can only be one ssl ctx function, we need to move both tasks into one function.
sni
force-pushed
the
fix_check_curl_ssl_eof
branch
from
302efa1 to
528e92c
Compare
Contributor
Author
|
finally all tests are green and i tested this patch on debian11/12 and rhel7/8/9. Looked good, |
andreasbaumann
approved these changes
Oct 10, 2024
RincewindsHat
approved these changes
Oct 10, 2024
Member
RincewindsHat
left a comment
RincewindsHat
left a comment
There was a problem hiding this comment.
ok, good enough for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix check_curl: OpenSSL SSL_read: error:0A000126:SSL routines::unexpected eof while reading, errno 0
using check_curl on a probably embedded device responding as 'Server: GoAhead-Webs'
reading the discussion on openssl/openssl#22690 suggest to set the option SSL_OP_IGNORE_UNEXPECTED_EOF which makes check_curl behave like check_http at this point. Since this is a rather new flag, fencing it in ifdefs.
And since there can only be one ssl ctx function, we need to move both tasks into one function.