Refactor check_swap #1976
Merged
Refactor check_swap #1976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@sni would you like to take a look at this? |
Contributor
|
yeah, when i have 3 weeks of vacation ;) |
Member
Author
|
Can I sweet talk your company into giving you that? :-P |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of refactoring
check_swap, which was started because theifdefhell in there was annoying me.The results are the following:
swap.c) in a separate directory (check_swap.d) although the naming and the positions are up for discussionplugins/tests/test_check_swap.c(and the corresponding curl test program)mainincheck_swapnow only deals with computing the result and formatting the outputclang-formatat least once to achieve better readabilityCurrently this is probably not in a proper state to be merged, more tests would be appreciated and the structure of the files and so on is open for discussion.