Skip to content

Conversation

@eworm-de
Copy link

No description provided.

@eworm-de
Copy link
Author

This is the downstream report from Arch Linux bug tracker:
https://bugs.archlinux.org/task/48338

@waja waja added the bugfix label Jan 1, 2017
@waja waja added this to the 2.3 milestone Jan 1, 2017
@waja
Copy link
Member

waja commented Jan 4, 2017

#1412 seems related

@waja
Copy link
Member

waja commented Jan 4, 2017

@eworm-de if it isn't too much hassle for you, can you please rebase your PR against master? This might fix the travis checks.

@eworm-de
Copy link
Author

eworm-de commented Jan 4, 2017

Already did that before you requested. ;)

Copy link
Contributor

@sni sni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@waja
Copy link
Member

waja commented Sep 18, 2023

Is this still needed? It's rotting since 5 years and longer but things seems to work without that change.

@eworm-de
Copy link
Author

For Arch Linux this works as we configure with --with-ping-command='/usr/bin/ping -4 -n -U -w %d -c %d %s' --with-ping6-command='/usr/bin/ping -6 -n -U -w %d -c %d %s'...

https://gitlab.archlinux.org/archlinux/packaging/packages/monitoring-plugins/-/blob/main/PKGBUILD?ref_type=heads#L31

@waja
Copy link
Member

waja commented Sep 18, 2023

I guess this is be done by every maintainer. In Debian we do:

ifeq ($(DEB_HOST_ARCH_OS),linux)
PING_CONFIGURE_ARGS = --with-ping-command="/bin/ping -4 -n -U -w %d -c %d %s" \
                      --with-ping6-command="/bin/ping -6 -n -U -w %d -c %d %s"
else
PING_CONFIGURE_ARGS = --with-ping-command="/bin/ping -n -w %d -c %d %s" \
                      --with-ping6-command="/bin/ping6 -n -w %d -c %d %s"
endif

@waja
Copy link
Member

waja commented Sep 18, 2023

If nobody is complaining, I would prefer to close this one ...

@eworm-de
Copy link
Author

Configuring at build time is the way to go.

@eworm-de eworm-de closed this Sep 18, 2023
@RincewindsHat RincewindsHat mentioned this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants