check_curl: --post parameter takes URL decoded data, not encoded as help suggests #1978
Description
Based on what the help suggests, id=1 should not work but id%3D1 should.
The opposite is the true, either the help documentation or the behavior needs fixing.
[0] % '/usr/lib/monitoring-plugins/check_curl' --help | grep -e 'check_curl v'
check_curl v2.3.5 (monitoring-plugins 2.3.5) -P, --post=STRING
URL encoded http POST data[0] % '/usr/lib/monitoring-plugins/check_curl' '--hostname=www.bloody.com' '--post' 'id%3D1' '--sni' '--ssl=1.2+' '--string=V2023.1206_MUI' '--timeout=30' '--url=/en/Detailed.php' '--use-ipv4'
HTTP CRITICAL: HTTP/1.1 200 OK - string 'V2023.1206_MUI' not found on 'https://www.bloody.com:443/en/Detailed.php' - 149297 bytes in 1.646 second response time |time=1.646261s;;;0.000000;30.000000 size=149297B;;;0;
[2] % '/usr/lib/monitoring-plugins/check_curl' '--hostname=www.bloody.com' '--post' 'id=1' '--sni' '--ssl=1.2+' '--string=V2023.1206_MUI' '--timeout=30' '--url=/en/Detailed.php' '--use-ipv4'
HTTP OK: HTTP/1.1 200 OK - 158714 bytes in 1.653 second response time |time=1.652690s;;;0.000000;30.000000 size=158714B;;;0;