Skip to content

Conversation

@gagik
Copy link
Contributor

@gagik gagik commented Nov 15, 2024

VSCODE-618
When a users asks the participant something that results in code generation we provide a button to run the code. However, they may not be connected to an instance, so they can't run that code. At the moment if a user hits the > Run button while not connected we fail silently. This involves adding a connection flow when not connected. Similar to the Change active connection command handler.

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@gagik gagik marked this pull request as ready for review November 15, 2024 14:54
@gagik gagik requested review from Anemy and alenakhineika November 15, 2024 15:12
@gagik gagik merged commit 316d188 into main Nov 19, 2024
11 checks passed
@gagik gagik deleted the gagik/prompt-to-connect branch November 19, 2024 07:32
@alenakhineika
Copy link
Contributor

I tried it out yesterday and didn't click comment :) works well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants