feat(copilot): export to Language with Copilot VSCODE-573 #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…language-copilot # Conflicts: # src/participant/participant.ts # src/test/suite/participant/participant.test.ts # src/types/playgroundType.ts
Anemy
reviewed
Nov 11, 2024
Anemy
reviewed
Nov 12, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Looking good! Left a couple small suggestions/questions. I'll give this a run tomorrow
…language-copilot # Conflicts: # src/test/suite/participant/participant.test.ts
Anemy
approved these changes
Nov 14, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
lgtm. Left a few questions/suggestions and user experience suggestions.
Anemy
reviewed
Nov 18, 2024
Member
Anemy
left a comment
Anemy
left a comment
There was a problem hiding this comment.
Looks good, noticed 2 smaller things we probably want to change, and left one question.
…language-copilot # Conflicts: # src/participant/participant.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Motivation and Context
Open Questions
Types of changes