SERVER-122483 Add std::to_chars compatibility for macOS < 10.15#6
Merged
aditya8061 merged 1 commit intospidermonkey-esr140.7-cpp-onlyfrom Mar 24, 2026
Merged
Conversation
aditya8061
force-pushed
the
aditya.deshpande/SERVER-122483
branch
from
610a8fc to
4a2ef8c
Compare
leemaguire
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple's libc++ marks
std::to_charsas unavailable when the deployment target is below macOS 10.15. Backport branches (e.g. v7.0) that target older macOS versions fail to compile after the MozJS upgrade.This PR includes below changes:
MONGO_MOZJS_TO_CHARScompat macro injs/src/util/ToCharsCompat.hstd::to_charswith assertion wrapper (no behavioral change)std::to_chars(see oldInt32ToCStringWithBasein jsnum.cpp before ESR 140), adapted to be self-contained withoutmozilla::RangedPtr/mozilla::Absdependenciesstd::to_charscall sites across 4 files (jsnum.cpp,JSAtomUtils.cpp,BigIntType.cpp,TypedArrayObject.cpp)