Skip to content

SERVER-97404 remove ExclusiveData move constructor#4

Merged
jpbronsted merged 2 commits intospidermonkey-esr115.7-cpp-onlyfrom
james.bronsted/SERVER-97404
Nov 21, 2024
Merged

SERVER-97404 remove ExclusiveData move constructor#4
jpbronsted merged 2 commits intospidermonkey-esr115.7-cpp-onlyfrom
james.bronsted/SERVER-97404

Conversation

@jpbronsted
Copy link
Copy Markdown
Collaborator

No description provided.

@jpbronsted jpbronsted requested a review from sroches November 20, 2024 20:43
@jpbronsted
Copy link
Copy Markdown
Collaborator Author

The move constructor being deleted here causes a compile error on Clang 19. This is because it has a misspelled variable, and even when the spelling is corrected, it results in an attempt to move a variable that explicitly doesn't support move semantics. Earlier compilers don't catch this issue because this template is never instantiated; Clang 19 is capable of finding errors that would happen regardless of how the template parameters get instantiated.

Co-authored-by: Billy Donahue <[email protected]>
@jpbronsted jpbronsted merged commit 05eee40 into spidermonkey-esr115.7-cpp-only Nov 21, 2024
@jpbronsted jpbronsted deleted the james.bronsted/SERVER-97404 branch November 21, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants