SERVER-97404 remove ExclusiveData move constructor#4
Merged
jpbronsted merged 2 commits intospidermonkey-esr115.7-cpp-onlyfrom Nov 21, 2024
Merged
Conversation
Collaborator
Author
|
The move constructor being deleted here causes a compile error on Clang 19. This is because it has a misspelled variable, and even when the spelling is corrected, it results in an attempt to move a variable that explicitly doesn't support move semantics. Earlier compilers don't catch this issue because this template is never instantiated; Clang 19 is capable of finding errors that would happen regardless of how the template parameters get instantiated. |
BillyDonahue
approved these changes
Nov 20, 2024
Co-authored-by: Billy Donahue <[email protected]>
sroches
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.