Implement NettyByteBuf.asReadOnly #1841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Replaces #1825 with the bare minimum change to allow NettyByteBuf's to be able to log / have tracing. Without the duplication in |
Member
Author
rozza
changed the title
stIncMale
requested changes
Nov 26, 2025
driver-core/src/main/com/mongodb/internal/connection/netty/NettyByteBuf.java
Outdated
Show resolved
Hide resolved
…tyByteBuf.java Co-authored-by: Valentin Kovalenko <[email protected]>
Member
Author
|
@stIncMale done |
stIncMale
reviewed
Nov 27, 2025
driver-core/src/test/unit/com/mongodb/internal/connection/CompositeByteBufTest.java
Outdated
Show resolved
Hide resolved
…ositeByteBufTest.java Co-authored-by: Valentin Kovalenko <[email protected]>
Member
Author
|
@stIncMale cannot merge unless this gets an LGTM and passes all evergreen checks |
stIncMale
approved these changes
Dec 1, 2025
rozza
added a commit
to rozza/mongo-java-driver
that referenced
this pull request
Dec 2, 2025
CompositeByteBuf#duplicate should duplicate underlying buffers JAVA-5982 --------- Co-authored-by: Valentin Kovalenko <[email protected]>
rozza
added a commit
that referenced
this pull request
Dec 3, 2025
CompositeByteBuf#duplicate should duplicate underlying buffers JAVA-5982 --------- Co-authored-by: Valentin Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5982