Remove assertion for verbose result #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
requested changes
Nov 1, 2025
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Outdated
Show resolved
Hide resolved
vbabanin
commented
Nov 13, 2025
| fail(writeModel.getClass().toString()); | ||
| } | ||
| if (okFieldValue == 1) { | ||
| collectSuccessfulIndividualOperationResult( |
Member
Author
There was a problem hiding this comment.
The TODO comments made the method larger and harder to follow. To keep the control flow maintainable, I moved one of the logical branches into a separate method. This keeps the main if/else structure concise and makes each path easier to identify and understand.
…tBulkWriteOperationTest.java Co-authored-by: Copilot <[email protected]>
stIncMale
requested changes
Nov 27, 2025
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/operation/ClientBulkWriteOperationTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/DualMessageSequences.java
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/operation/ClientBulkWriteOperationTest.java
Outdated
Show resolved
Hide resolved
stIncMale
approved these changes
Dec 3, 2025
vbabanin
added a commit
to vbabanin/mongo-java-driver
that referenced
this pull request
Dec 3, 2025
- Remove an assertion that was failing due to server bug SERVER-113344 where successful operation results are unexpectedly returned in the cursor when verbose results are disabled. - Add unit tests for JAVA-6001 and JAVA-5986. JAVA-6001 JAVA-5986 --------- Co-authored-by: Ross Lawley <[email protected]> (cherry picked from commit 96d0c6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses server bug SERVER-113344 by modifying the client-side bulk write operation handling to work around unexpected server responses.
The changes:
JAVA-6001
JAVA-5986