Skip to content

Stop ignoring id parameter#1622

Merged
katcharov merged 1 commit intomongodb:mainfrom
katcharov:JAVA-5728
Feb 11, 2025
Merged

Stop ignoring id parameter#1622
katcharov merged 1 commit intomongodb:mainfrom
katcharov:JAVA-5728

Conversation

@katcharov
Copy link
Copy Markdown
Collaborator

@katcharov katcharov requested review from a team and vbabanin and removed request for a team February 5, 2025 14:27
@rozza
Copy link
Copy Markdown
Member

rozza commented Feb 6, 2025

Recommend adding a regression test here: GridFSPublisherSpecification

@jyemin jyemin requested review from jyemin and removed request for vbabanin February 10, 2025 13:44
Copy link
Copy Markdown
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without a test, but please open a ticket to investigate the seemingly total lack of testing.

@katcharov
Copy link
Copy Markdown
Collaborator Author

@katcharov katcharov merged commit e4e5e69 into mongodb:main Feb 11, 2025
@katcharov katcharov deleted the JAVA-5728 branch February 11, 2025 14:58
katcharov added a commit to katcharov/mongo-java-driver that referenced this pull request Feb 13, 2025
katcharov added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants