Skip to content

Gradle updated to use version catalogs#1620

Merged
rozza merged 2 commits intomongodb:mainfrom
rozza:JAVA-5291
Feb 5, 2025
Merged

Gradle updated to use version catalogs#1620
rozza merged 2 commits intomongodb:mainfrom
rozza:JAVA-5291

Conversation

@rozza
Copy link
Copy Markdown
Member

@rozza rozza commented Jan 29, 2025

No description provided.

@rozza rozza force-pushed the JAVA-5291 branch 3 times, most recently from 7b7c765 to a437bb6 Compare January 30, 2025 09:48
@rozza rozza marked this pull request as ready for review January 30, 2025 11:59
@rozza rozza requested a review from nhachicha January 30, 2025 11:59
@rozza
Copy link
Copy Markdown
Member Author

rozza commented Jan 30, 2025 •
edited
Loading

Note: the apply plugin: "<plugin-name>" syntax doesn't work with libs.versions.toml eg:

configure(scalaProjects) {
    apply plugin: "java-library"
    apply plugin: "scala"
    apply plugin: "com.adtran.scala-multiversion-plugin"
    apply plugin: "com.diffplug.spotless"

As this is legacy syntax it'll be refactored out when going to convention based build logic in JAVA-5758

nhachicha
nhachicha reviewed Feb 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat using the catalogue 🎉

Comment thread gradle/libs.versions.toml
Comment thread build.gradle
@@ -251,25 +222,19 @@ configure(javaCodeCheckedProjects) {
apply plugin: 'com.adarshr.test-logger'

dependencies {
Copy link
Copy Markdown
Collaborator

@nhachicha nhachicha Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dependencies were removed here, are they redundant?

Copy link
Copy Markdown
Member Author

@rozza rozza Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we take advantage of bundles in the version catalog - which expands out to the same thing.

Comment thread build.gradle
@rozza rozza requested a review from nhachicha February 3, 2025 13:47
@rozza rozza merged commit e80cb0b into mongodb:main Feb 5, 2025
@rozza rozza deleted the JAVA-5291 branch February 5, 2025 11:58
@rozza rozza mentioned this pull request Feb 6, 2025
Merged
@rozza rozza restored the JAVA-5291 branch February 6, 2025 10:15
@rozza rozza deleted the JAVA-5291 branch February 6, 2025 10:16
@rozza
Copy link
Copy Markdown
Member Author

rozza commented Feb 6, 2025

Accidently merged into main - reverted in: #1624 merged into gradle branch in #1625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nhachicha nhachicha nhachicha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rozza @nhachicha