Fix test cleanup to prevent conflicts between tests.#1608
Merged
vbabanin merged 7 commits intomongodb:mainfrom Jan 21, 2025
Merged
Fix test cleanup to prevent conflicts between tests.#1608vbabanin merged 7 commits intomongodb:mainfrom
vbabanin merged 7 commits intomongodb:mainfrom
Conversation
jyemin
approved these changes
Jan 15, 2025
Collaborator
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
Approved, but wondering whether ClientSideEncryptionExternalKeyVaultTest should also do some cleanup, e.g. drop the collection.
jyemin
requested changes
Jan 15, 2025
jyemin
approved these changes
Jan 15, 2025
JAVA-5761
Collaborator
|
Let me know why the collection name change had to be reverted. |
Member
Author
Initially, the calculation of bytes to be subtracted from the available bytes for the message in the batch-splitting test was defined as 1122 in the spec tests. After changing the namespace, the test started failing. I reverted the change but later found a way to recalculate it. The test and namespace have now been updated accordingly. |
jyemin
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JAVA-5761