Skip to content

Add equals operator to Atlas Search#1606

Merged
katcharov merged 18 commits intomongodb:mainfrom
joykim1005:JAVA-5729
Jan 28, 2025
Merged

Add equals operator to Atlas Search#1606
katcharov merged 18 commits intomongodb:mainfrom
joykim1005:JAVA-5729

Conversation

@joykim1005
Copy link
Copy Markdown
Contributor

@joykim1005 joykim1005 commented Jan 14, 2025 •
edited
Loading

Ticket

JAVA-5729

Description

There are several Atlas Search query operators that are not implemented with first class support in the Java driver. This PR adds the equals operator to Atlas Search.

Testing

  • ran ./gradlew check
  • ran atlas-search-test on Evergreen
  • ran SearchOperatorTest
  • ran all Evergreen patch

@joykim1005 joykim1005 changed the title Java 5729 Add equals operator Jan 14, 2025
@joykim1005 joykim1005 self-assigned this Jan 14, 2025
@joykim1005 joykim1005 changed the title Add equals operator Add equals operator to Atlas Search Jan 14, 2025
@joykim1005
Copy link
Copy Markdown
Contributor Author

joykim1005 commented Jan 15, 2025 •
edited
Loading

com.mongodb.client.ClientSideEncryptionE…estExternal_withExternalKeyVault__false is failing and is unlikely caused by this PR and is happening in others as well.

@joykim1005 joykim1005 marked this pull request as ready for review January 15, 2025 19:29
@joykim1005 joykim1005 requested a review from katcharov January 15, 2025 19:29
katcharov
katcharov reviewed Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments - possibly no changes needed.

Comment thread driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
Comment thread driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
katcharov
katcharov reviewed Jan 16, 2025
View reviewed changes
Comment thread driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
katcharov
katcharov reviewed Jan 16, 2025
View reviewed changes
Comment thread driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java Outdated
}

/**
* Returns a {@link SearchOperator} that checks whether a field matches a value you specify.
Copy link
Copy Markdown
Collaborator

@katcharov katcharov Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs from our docs page are confusing. I think we should say, ...that searches for documents where a field matches the specified value. in all of these

stIncMale
stIncMale reviewed Jan 16, 2025
View reviewed changes
Comment thread driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
@stIncMale stIncMale mentioned this pull request Jan 16, 2025
Merged
4 tasks
@katcharov
Merge remote-tracking branch 'stIncMale/main' into JAVA-5729
8dba91c 
# Conflicts:
#	driver-core/src/main/com/mongodb/client/model/search/SearchConstructibleBsonElement.java
#	driver-core/src/main/com/mongodb/client/model/search/SearchOperator.java
#	driver-core/src/test/functional/com/mongodb/client/model/search/AggregatesSearchIntegrationTest.java
#	driver-core/src/test/unit/com/mongodb/client/model/search/SearchOperatorTest.java
#	driver-scala/src/main/scala/org/mongodb/scala/model/search/SearchOperator.scala
#	driver-scala/src/main/scala/org/mongodb/scala/model/search/package.scala
@katcharov
Clarify docs
013310a
@katcharov katcharov requested a review from stIncMale January 24, 2025 20:01
stIncMale
stIncMale approved these changes Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@stIncMale stIncMale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last reviewed commit is 013310a. I have not fully reviewed the commits before it.

@katcharov katcharov merged commit 0e25654 into mongodb:main Jan 28, 2025
@katcharov
Copy link
Copy Markdown
Collaborator

katcharov commented Jan 28, 2025

I reviewed the commits before that commit.

rozza pushed a commit that referenced this pull request Feb 6, 2025
@joykim1005 @katcharov @rozza
Add equals operator to Atlas Search (#1606)
b9dad3e 
JAVA-5729

---------

Co-authored-by: Maxim Katcharov <[email protected]>
@luketn
Copy link
Copy Markdown

luketn commented Mar 17, 2025

@joykim1005 thanks for this! It'll get rid of annoying helper methods I had to add to my code for the purpose like:

    private static SearchOperator equals(String fieldName, Object value) {
        return SearchOperator.of(
                new Document("equals", new Document()
                        .append("path", fieldName)
                        .append("value", value)
                ));
    }

So much nicer to have the specific method and overloads for each supported type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katcharov katcharov katcharov left review comments

@stIncMale stIncMale stIncMale approved these changes

Assignees

@joykim1005 joykim1005

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joykim1005 @katcharov @luketn @stIncMale