Make AbstractClientUpdateModel implement ClientWriteModel
#1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
commented
Jan 9, 2025
| * This class is not part of the public API and may be removed or changed at any time. | ||
| */ | ||
| public abstract class AbstractClientUpdateModel<O extends AbstractClientUpdateOptions> { | ||
| public abstract class AbstractClientUpdateModel<O extends AbstractClientUpdateOptions> implements ClientWriteModel { |
Member
Author
There was a problem hiding this comment.
AbstractClientDeleteModel does this, so should AbstractClientUpdateModel. This way it's much easier to explore the type hierarchy from ClientWriteModel down to concrete types.
vbabanin
approved these changes
Jan 9, 2025
stIncMale
merged commit 6e2ce8c
into
mongodb:JAVA-4586_bulk-write
51 of 60 checks passed
stIncMale
deleted the
JAVA-4586_bulk-write_make-AbstractClientUpdateModel-implement-ClientWriteModel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5533