Optimize ObjectID sort and serdes#1582
Merged
jyemin merged 20 commits intomongodb:mainfrom Feb 6, 2025
Merged
Conversation
vbabanin
reviewed
Feb 4, 2025
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
Co-authored-by: Viacheslav Babanin <[email protected]>
bernd
added a commit
to Graylog2/graylog2-server
that referenced
this pull request
Mar 21, 2025
MongoDB's ObjectId hash code implementation changed, so we have to update the expected fingerprint. See: mongodb/mongo-java-driver#1582
bernd
added a commit
to Graylog2/graylog2-server
that referenced
this pull request
Mar 21, 2025
* Bump mongodb-driver.version from 5.3.1 to 5.4.0 Bumps `mongodb-driver.version` from 5.3.1 to 5.4.0. Updates `org.mongodb:mongodb-driver-sync` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/mongodb/mongo-java-driver/releases) - [Commits](mongodb/mongo-java-driver@r5.3.1...r5.4.0) Updates `org.mongodb:mongodb-driver-legacy` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/mongodb/mongo-java-driver/releases) - [Commits](mongodb/mongo-java-driver@r5.3.1...r5.4.0) --- updated-dependencies: - dependency-name: org.mongodb:mongodb-driver-sync dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.mongodb:mongodb-driver-legacy dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update expected fingerprint after ObjectId implementation changes MongoDB's ObjectId hash code implementation changed, so we have to update the expected fingerprint. See: mongodb/mongo-java-driver#1582 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bernd Ahlers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: JAVA-5388
Change in-memory representation of
ObjectIdto minimize number of comparisons for sorting.This representation also has a side effect of improving methods relating to serialization/deserialization and saving 2 bytes/object. The behavior of this class should remain unchanged except for trivial differences in
hashCode()Below are results of some JMH benchmarks measured by throughput