Clean up TestDef API, clarify naming #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katcharov
requested review from
a team and
nhachicha
and removed request for
a team
katcharov
force-pushed
the
skips-cleanup
branch
from
a24842c to
290842f
Compare
nhachicha
reviewed
Nov 25, 2024
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java
Outdated
Show resolved
Hide resolved
…fiedTestModifications.java Co-authored-by: Nabil Hachicha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1557, I neglected to push (optional) PR fixes before merging (naming, etc.). After merging, I saw I could move the assumption out of the API, which cleaned things up a bit.