Merged
Conversation
Don't output the host and port information if the port is invalid. Reduces risk of leaking password information if the password has not been correctly urlencoded. JAVA-5560
Member
Author
|
Note: In the unlikely case of the password looking like a port eg: within numeric range and ending in a slash |
jyemin
reviewed
Aug 2, 2024
Collaborator
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
Is there anything similarly dangerous in ConnectionString#parseHosts?
Member
Author
|
@jyemin I think all is covered. An unescaped
If the user were to accidently escape the I added a couple of extra regression tests. |
rozza
added a commit
to rozza/mongo-java-driver
that referenced
this pull request
Aug 7, 2024
Don't output the host and port information if the port is invalid. Reduces risk of leaking password information if the password has not been correctly urlencoded. JAVA-5560
rozza
added a commit
to rozza/mongo-java-driver
that referenced
this pull request
Aug 7, 2024
Don't output the host and port information if the port is invalid. Reduces risk of leaking password information if the password has not been correctly urlencoded. JAVA-5560
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't output the host and port information if the port is invalid. Reduces risk of leaking password information if the password has not been correctly urlencoded.
JAVA-5560