Skip to content

Refactor to use new static type checking features#180

Merged
mondeja merged 2 commits intomondeja:masterfrom
oprypin:typ
Oct 14, 2023
Merged

Refactor to use new static type checking features#180
mondeja merged 2 commits intomondeja:masterfrom
oprypin:typ

Conversation

@oprypin
Copy link
Copy Markdown
Contributor

@oprypin oprypin commented Oct 13, 2023

  • Use class-based config and attributes from MkDocs 1.4
  • Use dataclass from Python 3.8
  • Refactor: put runtime attributes onto the plugin rather than onto the config - also statically typed

Extra: actually depend on MkDocs, it is a dependency

* Use class-based config and attributes from MkDocs 1.4
* Use dataclass from Python 3.8
* Refactor: put runtime attributes onto the plugin rather than onto the config - also statically typed

Extra: actually depend on MkDocs, it is a dependency
Copy link
Copy Markdown
Owner

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you!

@mondeja mondeja merged commit 065c890 into mondeja:master Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants