[misc] Specify length of toArray return type #5766
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toArray will always return an array with seven numbers. This change is necessary to be able to do `new Date(...m.toArray())`. As just `number[]`, it complains with `Expected 0-7 arguments, but got 0 or more.`.
mongoose700
changed the title
Member
|
Interesting. Is this TS 1.x compatible? Otherwise, you can update the ts3.1 typings. |
Contributor
Author
|
Tuples were added in 1.3, so not quite. |
Member
|
@mongoose700 Thanks for the update. Could you also add a test https://github.com/moment/moment/blob/develop/ts3.1-typing-tests/moment-tests.ts and I'll merge it |
Contributor
Author
|
I wanted to add a test that invoked |
Member
|
Thanks! |
marwahaha
changed the title
aniki0220
pushed a commit
to aniki0220/moment
that referenced
this pull request
Feb 1, 2021
This reverts commit 52019f1.
This was referenced Apr 9, 2022
This was referenced Apr 9, 2022
quantumfs
approved these changes
Jun 13, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toArray will always return an array with seven numbers. This change is necessary to be able to do
new Date(...m.toArray()). As justnumber[], it complains withExpected 0-7 arguments, but got 0 or more..